Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all ed25519-dalek dependency to a published version #458

Closed
coleFD opened this issue Feb 27, 2023 · 4 comments
Closed

Update all ed25519-dalek dependency to a published version #458

coleFD opened this issue Feb 27, 2023 · 4 comments
Labels
important Needs to be done spec incompatibility Issues ensuring SRI follows the specs
Milestone

Comments

@coleFD
Copy link
Contributor

coleFD commented Feb 27, 2023

We cannot publish crates that have github dependencies, and because we need no_std support, we are currently depending on a fork of the original ed25519-dalek repo since the published version will not compile. We need to find a solution to point towards a published crate in noise_sv2, so we can publish the crate and the crates that depend on noise_sv2.

@xraid
Copy link
Contributor

xraid commented Feb 27, 2023

fork and massage it meanwhile ?

@coleFD
Copy link
Contributor Author

coleFD commented Feb 27, 2023

So version 2.0.0-pre.0 is out now and is apparently "supposed" to be compatible with no_std, but the curve25519-dalek crate version is incompatible with the one used by snow which is another noise_sv2 dependency. There is a possibility that we can get snow to bump their curve25519-dalek dependency to the same one used by ed25519-dalek. With that being said, we need to confirm that the 2.0.0-pre.0 version is actually no_std compatible. Also as a note, the pre-release version has an updated api so we will need to adjust the noise_sv2 crate to match.

Wrt the toml dependencies (#456), forking and publishing may be the only way to go. I dont see this as a big issue since we only use it to parse config files.

@pavlenex pavlenex added this to the Version 0.1 milestone Apr 22, 2023
@pavlenex pavlenex added important Needs to be done spec incompatibility Issues ensuring SRI follows the specs labels Apr 22, 2023
@pavlenex pavlenex moved this to Todo 📝 in SV2 Roadmap 🛣️ Apr 22, 2023
@pavlenex
Copy link
Collaborator

@Fi3 pointed out @lorbax could look into this to see if we use it, if not we can close it.

@pavlenex
Copy link
Collaborator

the curve ed25519-dalek was abondoned in favor of secp256k1

@github-project-automation github-project-automation bot moved this from Todo 📝 to Done ✅ in SV2 Roadmap 🛣️ Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Needs to be done spec incompatibility Issues ensuring SRI follows the specs
Projects
Archived in project
Development

No branches or pull requests

3 participants