Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all toml dependencies to a published version #456

Closed
coleFD opened this issue Feb 27, 2023 · 4 comments · Fixed by #1087
Closed

Update all toml dependencies to a published version #456

coleFD opened this issue Feb 27, 2023 · 4 comments · Fixed by #1087
Assignees

Comments

@coleFD
Copy link
Contributor

coleFD commented Feb 27, 2023

We cannot publish crates that have github dependencies, and because we need no_std support, we are currently depending on a fork of the original toml repo since the published version will not compile. toml is used in all of the roles crates to deserialize the config files so we need to fix each of them.

@pavlenex
Copy link
Collaborator

pavlenex commented May 1, 2024

@plebhash any updates if #812 (comment) affected this and if we can freely close it?

@plebhash
Copy link
Collaborator

plebhash commented May 3, 2024

#456 is still an unsolved issue

keeping track of this on the roles CLI standardization discussion: #857 (comment)

This was referenced May 26, 2024
Closed
@Shourya742
Copy link
Contributor

Removing the TOML dependency is a critical requirement for the integration test. The TOML dependency obstructs the addition of the Bitcoind crate because of its no_std constraint.
cc: @plebhash @jbesraa

@Shourya742
Copy link
Contributor

@plebhash , I'll create a separate PR to remove the TOML dependency from the roles. Could you assign the issue to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants