Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump protocols versioning #1084

Merged
merged 3 commits into from
Aug 9, 2024
Merged

bump protocols versioning #1084

merged 3 commits into from
Aug 9, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Aug 8, 2024 •
edited
Loading

after merging #976 we didn't properly manage versioning of framing_sv2 + codec_sv2 crates

this PR fixes this

hopefully this will not happen again once #985 is finally merged, as it will enforce semver on both dev and main branches

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

🐰Bencher

ReportFri, August 9, 2024 at 19:39:54 UTC
ProjectStratum v2 (SRI)
Branch1084/merge
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserializeLatency (nanoseconds (ns))🚨 (view plot | view alert)653.42 (+6.15%)648.30 (100.79%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,650.80 (-3.48%)7,389.77 (90.00%)
client-submit-serialize-deserialize✅ (view plot)7,443.80 (-4.73%)8,345.89 (89.19%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,008.60 (-4.47%)8,857.56 (90.42%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)891.16 (-0.88%)929.38 (95.89%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)721.55 (+3.24%)725.53 (99.45%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)252.03 (+1.37%)256.47 (98.27%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)158.46 (+0.64%)163.26 (97.06%)
client-sv1-get-submit✅ (view plot)6,344.50 (-4.73%)7,161.71 (88.59%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)285.57 (+2.44%)291.14 (98.09%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)752.35 (+0.49%)784.18 (95.94%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize🚨 (view plot | view alert)653.42 (+6.15%)648.30 (100.79%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)215.03 (+4.10%)220.03 (97.73%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

🐰Bencher

ReportFri, August 9, 2024 at 19:39:54 UTC
ProjectStratum v2 (SRI)
Branchpatch-protocols-versioning
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,399.00 (-0.47%)8,723.80 (96.28%)✅ (view plot)3,744.00 (+0.07%)3,854.31 (97.14%)✅ (view plot)5,259.00 (+0.23%)5,401.17 (97.37%)✅ (view plot)5.00 (-35.84%)10.52 (47.54%)✅ (view plot)89.00 (-1.19%)94.05 (94.63%)
get_submit✅ (view plot)95,550.00 (-0.01%)96,135.28 (99.39%)✅ (view plot)59,494.00 (+0.03%)59,774.93 (99.53%)✅ (view plot)85,460.00 (+0.06%)85,833.63 (99.56%)✅ (view plot)51.00 (-7.16%)62.35 (81.80%)✅ (view plot)281.00 (-0.40%)287.66 (97.69%)
get_subscribe✅ (view plot)7,960.00 (-0.26%)8,271.59 (96.23%)✅ (view plot)2,820.00 (-0.35%)2,937.44 (96.00%)✅ (view plot)3,945.00 (-0.23%)4,096.65 (96.30%)✅ (view plot)12.00 (-24.92%)19.95 (60.14%)✅ (view plot)113.00 (+0.20%)117.16 (96.45%)
serialize_authorize✅ (view plot)12,250.00 (+0.30%)12,511.52 (97.91%)✅ (view plot)5,315.00 (+0.05%)5,425.31 (97.97%)✅ (view plot)7,420.00 (+0.14%)7,564.40 (98.09%)✅ (view plot)7.00 (-33.66%)13.77 (50.82%)✅ (view plot)137.00 (+0.93%)140.61 (97.43%)
serialize_deserialize_authorize✅ (view plot)24,532.00 (+0.23%)24,719.67 (99.24%)✅ (view plot)9,922.00 (+0.20%)10,027.43 (98.95%)✅ (view plot)14,012.00 (+0.29%)14,154.80 (98.99%)✅ (view plot)32.00 (-11.87%)41.78 (76.60%)✅ (view plot)296.00 (+0.35%)298.09 (99.30%)
serialize_deserialize_handle_authorize✅ (view plot)30,128.00 (-0.06%)30,341.03 (99.30%)✅ (view plot)12,099.00 (+0.02%)12,209.31 (99.10%)✅ (view plot)17,128.00 (+0.05%)17,279.23 (99.12%)✅ (view plot)59.00 (+0.35%)64.57 (91.38%)✅ (view plot)363.00 (-0.23%)366.95 (98.92%)
serialize_deserialize_handle_submit✅ (view plot)126,637.00 (+0.17%)127,041.82 (99.68%)✅ (view plot)73,307.00 (+0.07%)73,616.90 (99.58%)✅ (view plot)105,087.00 (+0.09%)105,509.58 (99.60%)✅ (view plot)117.00 (-2.65%)131.02 (89.30%)✅ (view plot)599.00 (+0.65%)599.85 (99.86%)
serialize_deserialize_handle_subscribe✅ (view plot)27,430.00 (-0.10%)27,612.03 (99.34%)✅ (view plot)9,622.00 (-0.10%)9,739.44 (98.79%)✅ (view plot)13,615.00 (-0.06%)13,772.42 (98.86%)✅ (view plot)61.00 (-7.14%)73.62 (82.85%)✅ (view plot)386.00 (+0.03%)388.96 (99.24%)
serialize_deserialize_submit✅ (view plot)115,349.00 (+0.22%)115,674.80 (99.72%)✅ (view plot)68,167.00 (+0.15%)68,407.69 (99.65%)✅ (view plot)97,839.00 (+0.18%)98,162.94 (99.67%)✅ (view plot)65.00 (-6.06%)75.32 (86.30%)✅ (view plot)491.00 (+0.56%)492.67 (99.66%)
serialize_deserialize_subscribe✅ (view plot)22,938.00 (+0.24%)23,125.76 (99.19%)✅ (view plot)8,181.00 (-0.07%)8,295.61 (98.62%)✅ (view plot)11,528.00 (-0.02%)11,680.57 (98.69%)✅ (view plot)35.00 (-10.77%)44.08 (79.39%)✅ (view plot)321.00 (+0.70%)322.30 (99.60%)
serialize_submit✅ (view plot)99,961.00 (+0.06%)100,470.13 (99.49%)✅ (view plot)61,538.00 (+0.03%)61,824.14 (99.54%)✅ (view plot)88,306.00 (+0.05%)88,686.99 (99.57%)✅ (view plot)49.00 (-11.46%)62.55 (78.34%)✅ (view plot)326.00 (+0.36%)329.49 (98.94%)
serialize_subscribe✅ (view plot)11,399.00 (+0.56%)11,619.66 (98.10%)✅ (view plot)4,167.00 (-0.24%)4,284.44 (97.26%)✅ (view plot)5,799.00 (-0.23%)5,955.61 (97.37%)✅ (view plot)14.00 (-13.71%)19.04 (73.53%)✅ (view plot)158.00 (+1.61%)160.43 (98.49%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

🐰Bencher

ReportFri, August 9, 2024 at 19:39:50 UTC
ProjectStratum v2 (SRI)
Branchpatch-protocols-versioning
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.48 (-0.19%)45.23 (98.33%)
client_sv2_handle_message_mining✅ (view plot)74.94 (+2.79%)80.26 (93.37%)
client_sv2_mining_message_submit_standard✅ (view plot)14.67 (+0.10%)14.69 (99.84%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)270.80 (+2.20%)284.80 (95.09%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)571.58 (-3.81%)628.28 (90.98%)
client_sv2_open_channel✅ (view plot)169.94 (+2.37%)173.38 (98.01%)
client_sv2_open_channel_serialize✅ (view plot)271.32 (-3.91%)293.88 (92.32%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)378.20 (-0.00%)422.52 (89.51%)
client_sv2_setup_connection✅ (view plot)164.77 (+0.38%)174.60 (94.37%)
client_sv2_setup_connection_serialize✅ (view plot)460.56 (-2.93%)506.27 (90.97%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)1,014.30 (+4.51%)1,038.87 (97.63%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

🐰Bencher

ReportFri, August 9, 2024 at 19:39:55 UTC
ProjectStratum v2 (SRI)
Branchpatch-protocols-versioning
Testbedsv2

🚨 14 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonEstimated Cycles (estimated cycles)🚨 (view plot | view alert)2,157.00 (+5.02%)2,141.30 (100.73%)
client_sv2_handle_message_commonL2 Accesses (accesses)🚨 (view plot | view alert)13.00 (+79.42%)11.74 (110.72%)
client_sv2_handle_message_commonRAM Accesses (accesses)🚨 (view plot | view alert)39.00 (+6.11%)38.85 (100.39%)
client_sv2_mining_message_submit_standardL2 Accesses (accesses)🚨 (view plot | view alert)26.00 (+45.44%)23.92 (108.71%)
client_sv2_mining_message_submit_standard_serializeL2 Accesses (accesses)🚨 (view plot | view alert)57.00 (+19.49%)53.83 (105.89%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,591.00 (+0.43%)10,576.25 (100.14%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,400.00 (+0.37%)15,384.07 (100.10%)
client_sv2_mining_message_submit_standard_serialize_deserializeL2 Accesses (accesses)🚨 (view plot | view alert)91.00 (+8.27%)90.25 (100.83%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,027.00 (+0.51%)8,015.94 (100.14%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,666.00 (+0.42%)11,656.22 (100.08%)
client_sv2_open_channel_serialize_deserializeL2 Accesses (accesses)🚨 (view plot | view alert)87.00 (+17.62%)83.98 (103.59%)
client_sv2_setup_connection_serializeL2 Accesses (accesses)🚨 (view plot | view alert)50.00 (+11.68%)49.53 (100.95%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,855.00 (+0.28%)14,843.49 (100.08%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,811.00 (+0.26%)21,795.89 (100.07%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common🚨 (view plot | view alert)2,157.00 (+5.02%)2,141.30 (100.73%)✅ (view plot)473.00 (+0.57%)487.19 (97.09%)✅ (view plot)727.00 (-0.59%)756.11 (96.15%)🚨 (view plot | view alert)13.00 (+79.42%)11.74 (110.72%)🚨 (view plot | view alert)39.00 (+6.11%)38.85 (100.39%)
client_sv2_handle_message_mining✅ (view plot)8,221.00 (+0.26%)8,336.48 (98.61%)✅ (view plot)2,143.00 (+0.70%)2,171.82 (98.67%)✅ (view plot)3,166.00 (+0.64%)3,216.31 (98.44%)✅ (view plot)38.00 (-1.10%)43.46 (87.43%)✅ (view plot)139.00 (+0.08%)141.96 (97.91%)
client_sv2_mining_message_submit_standard✅ (view plot)6,322.00 (+0.72%)6,391.79 (98.91%)✅ (view plot)1,756.00 (+0.37%)1,764.38 (99.53%)✅ (view plot)2,552.00 (-0.05%)2,576.66 (99.04%)🚨 (view plot | view alert)26.00 (+45.44%)23.92 (108.71%)✅ (view plot)104.00 (+0.15%)106.91 (97.28%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,841.00 (+0.43%)15,032.71 (98.72%)✅ (view plot)4,700.00 (+0.14%)4,708.38 (99.82%)✅ (view plot)6,751.00 (-0.04%)6,775.96 (99.63%)🚨 (view plot | view alert)57.00 (+19.49%)53.83 (105.89%)✅ (view plot)223.00 (+0.25%)229.84 (97.02%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,615.00 (+0.48%)27,845.90 (99.17%)🚨 (view plot | view alert)10,591.00 (+0.43%)10,576.25 (100.14%)🚨 (view plot | view alert)15,400.00 (+0.37%)15,384.07 (100.10%)🚨 (view plot | view alert)91.00 (+8.27%)90.25 (100.83%)✅ (view plot)336.00 (+0.34%)345.10 (97.36%)
client_sv2_open_channel✅ (view plot)4,315.00 (-3.64%)4,637.50 (93.05%)✅ (view plot)1,461.00 (+0.09%)1,475.51 (99.02%)✅ (view plot)2,160.00 (+0.34%)2,174.13 (99.35%)✅ (view plot)11.00 (-7.11%)15.25 (72.14%)✅ (view plot)60.00 (-7.34%)68.91 (87.07%)
client_sv2_open_channel_serialize✅ (view plot)14,032.00 (-1.20%)14,467.99 (96.99%)✅ (view plot)5,064.00 (+0.02%)5,078.51 (99.71%)✅ (view plot)7,322.00 (+0.06%)7,339.96 (99.76%)✅ (view plot)40.00 (+7.55%)42.30 (94.55%)✅ (view plot)186.00 (-2.81%)199.02 (93.46%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,671.00 (+0.15%)23,013.47 (98.51%)🚨 (view plot | view alert)8,027.00 (+0.51%)8,015.94 (100.14%)🚨 (view plot | view alert)11,666.00 (+0.42%)11,656.22 (100.08%)🚨 (view plot | view alert)87.00 (+17.62%)83.98 (103.59%)✅ (view plot)302.00 (-0.76%)314.67 (95.97%)
client_sv2_setup_connection✅ (view plot)4,689.00 (-0.15%)4,767.64 (98.35%)✅ (view plot)1,502.00 (+0.08%)1,516.51 (99.04%)✅ (view plot)2,274.00 (-0.09%)2,300.63 (98.84%)✅ (view plot)14.00 (+49.72%)14.28 (98.05%)✅ (view plot)67.00 (-1.19%)69.67 (96.16%)
client_sv2_setup_connection_serialize✅ (view plot)16,116.00 (-0.84%)16,494.78 (97.70%)✅ (view plot)5,963.00 (+0.02%)5,977.51 (99.76%)✅ (view plot)8,656.00 (+0.01%)8,678.16 (99.74%)🚨 (view plot | view alert)50.00 (+11.68%)49.53 (100.95%)✅ (view plot)206.00 (-2.22%)217.62 (94.66%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,566.00 (+0.09%)35,744.43 (99.50%)🚨 (view plot | view alert)14,855.00 (+0.28%)14,843.49 (100.08%)🚨 (view plot | view alert)21,811.00 (+0.26%)21,795.89 (100.07%)✅ (view plot)105.00 (+5.28%)112.64 (93.22%)✅ (view plot)378.00 (-0.37%)384.53 (98.30%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@plebhash plebhash changed the title patch protocols versioning bump protocols versioning Aug 9, 2024
@plebhash plebhash force-pushed the patch-protocols-versioning branch 2 times, most recently from f8b7233 to 9c0abe1 Compare August 9, 2024 18:51
@plebhash plebhash merged commit d376b17 into stratum-mining:dev Aug 9, 2024
32 checks passed
@plebhash plebhash deleted the patch-protocols-versioning branch August 9, 2024 20:13
This was referenced Aug 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrybarczyk rrybarczyk rrybarczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plebhash @rrybarczyk