Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version 1.75.0 of toolchain in scripts #1168

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Use version 1.75.0 of toolchain in scripts #1168

merged 1 commit into from
Sep 19, 2024

Conversation

lorbax
Copy link
Collaborator

@lorbax lorbax commented Sep 18, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch1168/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,783.30
(-0.61%)		7,523.45
(90.16%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,643.00
(-2.42%)		8,720.60
(87.64%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,363.70
(-0.59%)		9,197.60
(90.93%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		908.49
(-0.86%)		985.79
(92.16%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		719.07
(+0.40%)		765.02
(93.99%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		247.27
(-1.06%)		263.16
(93.96%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		159.02
(+0.72%)		166.55
(95.48%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,636.70
(+0.43%)		7,253.04
(91.50%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		274.91
(-0.45%)		301.09
(91.30%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		770.81
(+0.46%)		830.12
(92.86%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		641.40
(+2.02%)		682.95
(93.92%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		200.01
(-4.21%)		229.69
(87.08%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch1168/merge@9cfe4d58-7043-438e-a153-89785c694b6e
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,507.00
(+0.73%)		8,792.64
(96.75%)		📈 view plot
🚷 view threshold		3,772.00
(+0.63%)		3,881.43
(97.18%)		📈 view plot
🚷 view threshold		5,297.00
(+0.76%)		5,440.11
(97.37%)		📈 view plot
🚷 view threshold		5.00
(-28.33%)		11.67
(42.85%)		📈 view plot
🚷 view threshold		91.00
(+0.99%)		95.30
(95.49%)
get_submit📈 view plot
🚷 view threshold		95,460.00
(-0.02%)		96,198.60
(99.23%)		📈 view plot
🚷 view threshold		59,522.00
(+0.09%)		59,795.52
(99.54%)		📈 view plot
🚷 view threshold		85,510.00
(+0.11%)		85,873.77
(99.58%)		📈 view plot
🚷 view threshold		44.00
(-7.90%)		71.70
(61.37%)		📈 view plot
🚷 view threshold		278.00
(-0.97%)		289.96
(95.88%)
get_subscribe📈 view plot
🚷 view threshold		8,072.00
(+0.79%)		8,359.84
(96.56%)		📈 view plot
🚷 view threshold		2,848.00
(+0.40%)		2,963.81
(96.09%)		📈 view plot
🚷 view threshold		3,982.00
(+0.42%)		4,135.71
(96.28%)		📈 view plot
🚷 view threshold		13.00
(+0.60%)		23.20
(56.04%)		📈 view plot
🚷 view threshold		115.00
(+1.15%)		119.63
(96.13%)
serialize_authorize📈 view plot
🚷 view threshold		12,282.00
(+0.22%)		12,633.38
(97.22%)		📈 view plot
🚷 view threshold		5,343.00
(+0.45%)		5,452.43
(97.99%)		📈 view plot
🚷 view threshold		7,462.00
(+0.58%)		7,602.49
(98.15%)		📈 view plot
🚷 view threshold		5.00
(-45.53%)		15.13
(33.05%)		📈 view plot
🚷 view threshold		137.00
(+0.11%)		143.64
(95.38%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,953.00
(+1.39%)		25,141.68
(99.25%)		📈 view plot
🚷 view threshold		9,920.00
(+0.25%)		10,053.03
(98.68%)		📈 view plot
🚷 view threshold		14,018.00
(+0.37%)		14,197.58
(98.74%)		📈 view plot
🚷 view threshold		31.00
(-11.70%)		44.58
(69.54%)		📈 view plot
🚷 view threshold		308.00
(+2.99%)		313.24
(98.33%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,511.00
(+0.83%)		30,717.47
(99.33%)		📈 view plot
🚷 view threshold		12,097.00
(+0.06%)		12,226.94
(98.94%)		📈 view plot
🚷 view threshold		17,136.00
(+0.11%)		17,307.97
(99.01%)		📈 view plot
🚷 view threshold		57.00
(+1.42%)		68.58
(83.12%)		📈 view plot
🚷 view threshold		374.00
(+1.77%)		380.57
(98.27%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,637.00
(+0.14%)		127,169.28
(99.58%)		📈 view plot
🚷 view threshold		73,363.00
(+0.12%)		73,671.99
(99.58%)		📈 view plot
🚷 view threshold		105,192.00
(+0.14%)		105,617.27
(99.60%)		📈 view plot
🚷 view threshold		110.00
(-0.26%)		142.28
(77.31%)		📈 view plot
🚷 view threshold		597.00
(+0.15%)		604.61
(98.74%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		28,093.00
(+1.38%)		28,575.79
(98.31%)		📈 view plot
🚷 view threshold		9,666.00
(+0.21%)		9,779.22
(98.84%)		📈 view plot
🚷 view threshold		13,673.00
(+0.21%)		13,829.73
(98.87%)		📈 view plot
🚷 view threshold		63.00
(-1.20%)		75.87
(83.04%)		📈 view plot
🚷 view threshold		403.00
(+2.61%)		415.82
(96.92%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,517.00
(+0.29%)		115,893.91
(99.67%)		📈 view plot
🚷 view threshold		68,223.00
(+0.20%)		68,473.31
(99.63%)		📈 view plot
🚷 view threshold		97,932.00
(+0.24%)		98,284.78
(99.64%)		📈 view plot
🚷 view threshold		66.00
(+3.09%)		81.90
(80.59%)		📈 view plot
🚷 view threshold		493.00
(+0.56%)		499.11
(98.78%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,495.00
(+1.57%)		23,988.85
(97.94%)		📈 view plot
🚷 view threshold		8,225.00
(+0.30%)		8,334.76
(98.68%)		📈 view plot
🚷 view threshold		11,590.00
(+0.34%)		11,736.53
(98.75%)		📈 view plot
🚷 view threshold		36.00
(-4.79%)		45.31
(79.44%)		📈 view plot
🚷 view threshold		335.00
(+2.92%)		347.65
(96.36%)
serialize_submit📈 view plot
🚷 view threshold		99,857.00
(-0.02%)		100,540.30
(99.32%)		📈 view plot
🚷 view threshold		61,566.00
(+0.09%)		61,844.22
(99.55%)		📈 view plot
🚷 view threshold		88,352.00
(+0.11%)		88,725.81
(99.58%)		📈 view plot
🚷 view threshold		47.00
(-4.08%)		70.71
(66.47%)		📈 view plot
🚷 view threshold		322.00
(-0.91%)		333.30
(96.61%)
serialize_subscribe📈 view plot
🚷 view threshold		11,401.00
(+0.13%)		11,759.60
(96.95%)		📈 view plot
🚷 view threshold		4,195.00
(+0.27%)		4,310.81
(97.31%)		📈 view plot
🚷 view threshold		5,841.00
(+0.32%)		5,992.69
(97.47%)		📈 view plot
🚷 view threshold		13.00
(-4.91%)		22.27
(58.37%)		📈 view plot
🚷 view threshold		157.00
(-0.00%)		164.52
(95.43%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch1168/merge
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.72
(+0.06%)		46.65
(95.87%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		80.32
(+6.74%)		92.53
(86.81%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.67
(-0.02%)		14.81
(99.07%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		265.27
(-1.03%)		291.37
(91.04%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		581.45
(-1.88%)		650.56
(89.38%)
client_sv2_open_channel📈 view plot
🚷 view threshold		163.70
(-1.36%)		177.79
(92.08%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		281.62
(+1.70%)		307.59
(91.56%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		380.16
(+0.64%)		459.17
(82.79%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		178.39
(+9.98%)		187.39
(95.20%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		433.59
(-5.03%)		568.61
(76.25%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		974.06
(-2.34%)		1,162.88
(83.76%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch1168/merge
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,129.00
(+2.52%)		2,208.21
(96.41%)		📈 view plot
🚷 view threshold		473.00
(+0.23%)		490.92
(96.35%)		📈 view plot
🚷 view threshold		734.00
(+0.00%)		762.12
(96.31%)		📈 view plot
🚷 view threshold		6.00
(+1.76%)		14.40
(41.66%)		📈 view plot
🚷 view threshold		39.00
(+3.94%)		41.21
(94.63%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,208.00
(+0.10%)		8,351.97
(98.28%)		📈 view plot
🚷 view threshold		2,137.00
(+0.17%)		2,180.29
(98.01%)		📈 view plot
🚷 view threshold		3,158.00
(+0.12%)		3,229.79
(97.78%)		📈 view plot
🚷 view threshold		37.00
(+0.89%)		45.39
(81.51%)		📈 view plot
🚷 view threshold		139.00
(+0.05%)		142.37
(97.63%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,327.00
(+0.76%)		6,418.06
(98.58%)		📈 view plot
🚷 view threshold		1,750.00
(-0.02%)		1,768.29
(98.97%)		📈 view plot
🚷 view threshold		2,547.00
(-0.26%)		2,581.09
(98.68%)		📈 view plot
🚷 view threshold		21.00
(+23.12%)		24.91
(84.32%)		📈 view plot
🚷 view threshold		105.00
(+0.95%)		107.81
(97.40%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,796.00
(+0.33%)		15,056.64
(98.27%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,712.29
(99.61%)		📈 view plot
🚷 view threshold		6,751.00
(-0.09%)		6,784.15
(99.51%)		📈 view plot
🚷 view threshold		48.00
(+7.99%)		55.23
(86.90%)		📈 view plot
🚷 view threshold		223.00
(+0.49%)		230.52
(96.74%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,608.00
(+0.38%)		27,896.22
(98.97%)		📈 view plot
🚷 view threshold		10,585.00
(+0.18%)		10,639.13
(99.49%)		📈 view plot
🚷 view threshold		15,398.00
(+0.15%)		15,481.60
(99.46%)		📈 view plot
🚷 view threshold		83.00
(+1.56%)		90.57
(91.64%)		📈 view plot
🚷 view threshold		337.00
(+0.65%)		345.97
(97.41%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,413.00
(-0.21%)		4,670.93
(94.48%)		📈 view plot
🚷 view threshold		1,461.00
(+0.03%)		1,478.14
(98.84%)		📈 view plot
🚷 view threshold		2,158.00
(+0.04%)		2,186.17
(98.71%)		📈 view plot
🚷 view threshold		10.00
(+2.38%)		18.53
(53.97%)		📈 view plot
🚷 view threshold		63.00
(-0.51%)		69.91
(90.11%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,088.00
(-0.15%)		14,528.48
(96.97%)		📈 view plot
🚷 view threshold		5,064.00
(+0.01%)		5,081.14
(99.66%)		📈 view plot
🚷 view threshold		7,323.00
(-0.00%)		7,353.70
(99.58%)		📈 view plot
🚷 view threshold		37.00
(+4.64%)		43.77
(84.53%)		📈 view plot
🚷 view threshold		188.00
(-0.44%)		200.76
(93.65%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,711.00
(+0.32%)		23,035.89
(98.59%)		📈 view plot
🚷 view threshold		8,027.00
(+0.24%)		8,079.39
(99.35%)		📈 view plot
🚷 view threshold		11,671.00
(+0.18%)		11,755.78
(99.28%)		📈 view plot
🚷 view threshold		80.00
(+8.59%)		85.23
(93.86%)		📈 view plot
🚷 view threshold		304.00
(+0.19%)		314.90
(96.54%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,711.00
(+0.50%)		4,785.22
(98.45%)		📈 view plot
🚷 view threshold		1,502.00
(+0.03%)		1,519.14
(98.87%)		📈 view plot
🚷 view threshold		2,276.00
(-0.07%)		2,305.10
(98.74%)		📈 view plot
🚷 view threshold		11.00
(+19.67%)		15.76
(69.79%)		📈 view plot
🚷 view threshold		68.00
(+0.66%)		70.30
(96.72%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,178.00
(-0.12%)		16,513.53
(97.97%)		📈 view plot
🚷 view threshold		5,963.00
(+0.01%)		5,980.14
(99.71%)		📈 view plot
🚷 view threshold		8,663.00
(+0.03%)		8,692.82
(99.66%)		📈 view plot
🚷 view threshold		40.00
(-3.27%)		54.91
(72.84%)		📈 view plot
🚷 view threshold		209.00
(-0.21%)		217.84
(95.94%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,544.00
(-0.01%)		35,781.50
(99.34%)		📈 view plot
🚷 view threshold		14,855.00
(+0.13%)		14,908.45
(99.64%)		📈 view plot
🚷 view threshold		21,824.00
(+0.15%)		21,911.67
(99.60%)		📈 view plot
🚷 view threshold		91.00
(-3.49%)		116.02
(78.43%)		📈 view plot
🚷 view threshold		379.00
(-0.15%)		385.09
(98.42%)
🐰 View full continuous benchmarking report in Bencher

@jbesraa
Copy link
Contributor

jbesraa commented Sep 18, 2024

@lorbax did you have any problem with a rust toolchain?

@lorbax
Copy link
Collaborator Author

lorbax commented Sep 19, 2024 •
edited
Loading

@lorbax did you have any problem with a rust toolchain?

Have we done anything about this issue?
#1048
if no, the same issues still remain. These scripts are used to ensure (on the developer side) that at least with 1.75 there are no clippy warnings.
It is annoying to write every time +1.75

@plebhash plebhash merged commit d61cd2a into stratum-mining:main Sep 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash approved these changes

@jbesraa jbesraa jbesraa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorbax @jbesraa @plebhash