Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cargo semver-checks v0.37 and bump crate versions as a follow-up to #1276 #1300

Merged
merged 19 commits into from
Dec 18, 2024
Merged

use cargo semver-checks v0.37 and bump crate versions as a follow-up to #1276 #1300

merged 19 commits into from
Dec 18, 2024

Conversation

plebhash
Copy link
Collaborator

follow up to #1276 according to this comment: #1275 (comment)

rationale

we are planning to remove more cargo build features in the future, and therefore it's desirable to enforce semver around this via CI

as a consequence, we need to use cargo semver-check v0.37 (or greater, but always locked)

this creates incompatibilities with MSRV, therefore we need to run cargo semver-check on stable

finally, switching cargo semver-check to v0.37 forced us to bump many crate versions

PR changes:

@plebhash plebhash marked this pull request as ready for review December 16, 2024 12:07
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.29%. Comparing base (e042650) to head (a4f8c43).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1300   +/-   ##
=======================================
  Coverage   19.29%   19.29%           
=======================================
  Files         164      164           
  Lines       10852    10852           
=======================================
  Hits         2094     2094           
  Misses       8758     8758
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.49% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

🐰 Bencher Report

Branchsemver-checks-37
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,422.00
(-0.44%)		8,678.80
(97.04%)		📈 view plot
🚷 view threshold		3,663.00
(-1.99%)		3,863.37
(94.81%)		📈 view plot
🚷 view threshold		5,107.00
(-2.45%)		5,449.68
(93.71%)		📈 view plot
🚷 view threshold		12.00
(+54.53%)		15.17
(79.10%)		📈 view plot
🚷 view threshold		93.00
(+2.20%)		95.85
(97.03%)
get_submit📈 view plot
🚷 view threshold		95,324.00
(-0.07%)		95,762.75
(99.54%)		📈 view plot
🚷 view threshold		59,263.00
(-0.28%)		59,715.76
(99.24%)		📈 view plot
🚷 view threshold		85,074.00
(-0.33%)		85,830.06
(99.12%)		📈 view plot
🚷 view threshold		48.00
(+8.69%)		59.06
(81.27%)		📈 view plot
🚷 view threshold		286.00
(+1.97%)		290.31
(98.51%)
get_subscribe📈 view plot
🚷 view threshold		7,935.00
(-0.94%)		8,232.82
(96.38%)		📈 view plot
🚷 view threshold		2,758.00
(-2.34%)		2,941.69
(93.76%)		📈 view plot
🚷 view threshold		3,830.00
(-2.87%)		4,140.85
(92.49%)		📈 view plot
🚷 view threshold		16.00
(+35.36%)		19.44
(82.29%)		📈 view plot
🚷 view threshold		115.00
(+0.42%)		117.73
(97.68%)
serialize_authorize📈 view plot
🚷 view threshold		12,207.00
(-0.54%)		12,510.70
(97.57%)		📈 view plot
🚷 view threshold		5,240.00
(-1.32%)		5,428.21
(96.53%)		📈 view plot
🚷 view threshold		7,277.00
(-1.65%)		7,605.08
(95.69%)		📈 view plot
🚷 view threshold		13.00
(+35.39%)		18.15
(71.64%)		📈 view plot
🚷 view threshold		139.00
(+0.81%)		142.09
(97.83%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,636.00
(-0.30%)		25,182.00
(97.83%)		📈 view plot
🚷 view threshold		9,786.00
(-0.89%)		10,031.44
(97.55%)		📈 view plot
🚷 view threshold		13,786.00
(-1.07%)		14,198.87
(97.09%)		📈 view plot
🚷 view threshold		35.00
(-0.22%)		45.22
(77.39%)		📈 view plot
🚷 view threshold		305.00
(+0.72%)		313.54
(97.28%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,227.00
(-0.34%)		30,709.67
(98.43%)		📈 view plot
🚷 view threshold		11,989.00
(-0.63%)		12,201.08
(98.26%)		📈 view plot
🚷 view threshold		16,952.00
(-0.77%)		17,309.37
(97.94%)		📈 view plot
🚷 view threshold		58.00
(+4.58%)		66.83
(86.79%)		📈 view plot
🚷 view threshold		371.00
(+0.12%)		379.58
(97.74%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,460.00
(-0.01%)		126,780.19
(99.75%)		📈 view plot
🚷 view threshold		73,117.00
(-0.21%)		73,524.01
(99.45%)		📈 view plot
🚷 view threshold		104,760.00
(-0.26%)		105,487.33
(99.31%)		📈 view plot
🚷 view threshold		112.00
(+5.97%)		123.84
(90.44%)		📈 view plot
🚷 view threshold		604.00
(+1.10%)		607.45
(99.43%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,837.00
(-0.20%)		28,459.05
(97.81%)		📈 view plot
🚷 view threshold		9,577.00
(-0.66%)		9,754.61
(98.18%)		📈 view plot
🚷 view threshold		13,517.00
(-0.85%)		13,828.03
(97.75%)		📈 view plot
🚷 view threshold		71.00
(+11.55%)		76.19
(93.18%)		📈 view plot
🚷 view threshold		399.00
(+0.17%)		412.43
(96.74%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,219.00
(-0.03%)		115,730.94
(99.56%)		📈 view plot
🚷 view threshold		67,894.00
(-0.27%)		68,420.77
(99.23%)		📈 view plot
🚷 view threshold		97,354.00
(-0.35%)		98,286.16
(99.05%)		📈 view plot
🚷 view threshold		73.00
(+14.88%)		83.41
(87.52%)		📈 view plot
🚷 view threshold		500.00
(+1.49%)		500.98
(99.80%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,252.00
(-0.24%)		23,861.95
(97.44%)		📈 view plot
🚷 view threshold		8,129.00
(-0.82%)		8,311.52
(97.80%)		📈 view plot
🚷 view threshold		11,422.00
(-1.02%)		11,736.84
(97.32%)		📈 view plot
🚷 view threshold		42.00
(+10.91%)		48.16
(87.20%)		📈 view plot
🚷 view threshold		332.00
(+0.35%)		344.05
(96.50%)
serialize_submit📈 view plot
🚷 view threshold		99,789.00
(-0.03%)		100,200.60
(99.59%)		📈 view plot
🚷 view threshold		61,325.00
(-0.25%)		61,742.59
(99.32%)		📈 view plot
🚷 view threshold		87,929.00
(-0.31%)		88,658.78
(99.18%)		📈 view plot
🚷 view threshold		55.00
(+17.41%)		64.47
(85.31%)		📈 view plot
🚷 view threshold		331.00
(+1.77%)		335.57
(98.64%)
serialize_subscribe📈 view plot
🚷 view threshold		11,418.00
(+0.09%)		11,613.43
(98.32%)		📈 view plot
🚷 view threshold		4,111.00
(-1.48%)		4,282.12
(96.00%)		📈 view plot
🚷 view threshold		5,688.00
(-1.94%)		5,993.54
(94.90%)		📈 view plot
🚷 view threshold		19.00
(+45.37%)		21.85
(86.96%)		📈 view plot
🚷 view threshold		161.00
(+1.68%)		163.45
(98.50%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

🐰 Bencher Report

Branchsemver-checks-37
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.81
(+0.66%)		46.64
(96.08%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		72.78
(-6.93%)		105.48
(69.00%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.66
(+0.02%)		14.71
(99.66%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		260.81
(-1.91%)		294.30
(88.62%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		605.55
(-1.18%)		650.78
(93.05%)
client_sv2_open_channel📈 view plot
🚷 view threshold		162.44
(-1.26%)		174.60
(93.04%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		291.83
(+2.42%)		310.34
(94.04%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		381.54
(-0.54%)		412.46
(92.50%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		159.96
(-0.11%)		171.69
(93.17%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		469.56
(-0.71%)		558.90
(84.02%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		956.81
(-3.66%)		1,089.23
(87.84%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

🐰 Bencher Report

Branchsemver-checks-37
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,457.40
(-2.41%)		7,085.19
(91.14%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,267.80
(-2.74%)		8,066.80
(90.10%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,961.80
(-2.25%)		9,475.89
(84.02%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		868.40
(+0.28%)		938.47
(92.53%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		667.25
(-0.76%)		717.21
(93.03%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		244.77
(-1.63%)		272.55
(89.81%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		155.74
(-0.92%)		167.13
(93.19%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,334.30
(-1.27%)		7,033.64
(90.06%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		283.01
(+0.84%)		304.11
(93.06%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		718.13
(-1.18%)		778.93
(92.19%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		587.16
(-0.04%)		614.89
(95.49%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		205.34
(-0.58%)		225.47
(91.07%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

🐰 Bencher Report

Branchsemver-checks-37
Testbedsv2

🚨 4 Alerts

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_handle_message_miningL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		42.00
(+18.41%)		41.73
(100.65%)
client_sv2_mining_message_submit_standard_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		100.00
(+21.35%)		95.43
(104.79%)
client_sv2_open_channel_serializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		47.00
(+32.10%)		45.97
(102.23%)
client_sv2_open_channel_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		94.00
(+25.39%)		87.42
(107.52%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,163.00
(+2.68%)		2,222.81
(97.31%)		📈 view plot
🚷 view threshold		473.00
(-0.06%)		489.01
(96.73%)		📈 view plot
🚷 view threshold		733.00
(-0.35%)		758.00
(96.70%)		📈 view plot
🚷 view threshold		6.00
(+15.49%)		13.26
(45.25%)		📈 view plot
🚷 view threshold		40.00
(+4.09%)		41.53
(96.32%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,330.00
(+1.37%)		8,369.42
(99.53%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,150.00
(-0.31%)		3,171.35
(99.33%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		42.00
(+18.41%)		41.73
(100.65%)		📈 view plot
🚷 view threshold		142.00
(+1.84%)		143.62
(98.87%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,357.00
(+0.97%)		6,437.28
(98.75%)		📈 view plot
🚷 view threshold		1,750.00
(-0.05%)		1,767.36
(99.02%)		📈 view plot
🚷 view threshold		2,547.00
(-0.21%)		2,576.08
(98.87%)		📈 view plot
🚷 view threshold		20.00
(+17.06%)		24.44
(81.82%)		📈 view plot
🚷 view threshold		106.00
(+1.42%)		108.44
(97.75%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,802.00
(+0.53%)		14,939.06
(99.08%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.36
(99.63%)		📈 view plot
🚷 view threshold		6,742.00
(-0.23%)		6,786.07
(99.35%)		📈 view plot
🚷 view threshold		58.00
(+30.54%)		59.02
(98.27%)		📈 view plot
🚷 view threshold		222.00
(+0.32%)		226.66
(97.94%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,824.00
(+0.92%)		27,960.53
(99.51%)		📈 view plot
🚷 view threshold		10,645.00
(+0.43%)		10,676.38
(99.71%)		📈 view plot
🚷 view threshold		15,494.00
(+0.44%)		15,557.61
(99.59%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		100.00
(+21.35%)		95.43
(104.79%)		📈 view plot
🚷 view threshold		338.00
(+0.83%)		342.17
(98.78%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,489.00
(+2.36%)		4,540.90
(98.86%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,477.01
(98.92%)		📈 view plot
🚷 view threshold		2,154.00
(-0.30%)		2,183.66
(98.64%)		📈 view plot
🚷 view threshold		12.00
(+44.77%)		14.66
(81.84%)		📈 view plot
🚷 view threshold		65.00
(+4.20%)		66.83
(97.26%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,094.00
(+0.55%)		14,192.46
(99.31%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,080.01
(99.68%)		📈 view plot
🚷 view threshold		7,314.00
(-0.17%)		7,351.32
(99.49%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		47.00
(+32.10%)		45.97
(102.23%)		📈 view plot
🚷 view threshold		187.00
(+0.49%)		191.14
(97.84%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,860.00
(+0.81%)		22,969.03
(99.53%)		📈 view plot
🚷 view threshold		8,040.00
(+0.12%)		8,052.01
(99.85%)		📈 view plot
🚷 view threshold		11,680.00
(-0.02%)		11,710.33
(99.74%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		94.00
(+25.39%)		87.42
(107.52%)		📈 view plot
🚷 view threshold		306.00
(+0.86%)		310.58
(98.53%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,719.00
(+0.71%)		4,784.04
(98.64%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,518.01
(98.95%)		📈 view plot
🚷 view threshold		2,274.00
(-0.18%)		2,299.51
(98.89%)		📈 view plot
🚷 view threshold		13.00
(+33.87%)		16.54
(78.57%)		📈 view plot
🚷 view threshold		68.00
(+0.88%)		70.01
(97.13%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,222.00
(+0.47%)		16,298.74
(99.53%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,979.01
(99.73%)		📈 view plot
🚷 view threshold		8,652.00
(-0.14%)		8,691.45
(99.55%)		📈 view plot
🚷 view threshold		51.00
(+27.43%)		54.31
(93.91%)		📈 view plot
🚷 view threshold		209.00
(+0.45%)		211.78
(98.69%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,794.00
(+0.62%)		35,864.93
(99.80%)		📈 view plot
🚷 view threshold		14,888.00
(+0.17%)		14,906.75
(99.87%)		📈 view plot
🚷 view threshold		21,864.00
(+0.13%)		21,904.64
(99.81%)		📈 view plot
🚷 view threshold		112.00
(+21.22%)		112.77
(99.32%)		📈 view plot
🚷 view threshold		382.00
(+0.72%)		384.85
(99.26%)
🐰 View full continuous benchmarking report in Bencher

GitGab19
GitGab19 reviewed Dec 16, 2024
View reviewed changes
protocols/v2/subprotocols/common-messages/Cargo.toml Outdated Show resolved Hide resolved
protocols/v2/subprotocols/job-declaration/Cargo.toml Outdated Show resolved Hide resolved
protocols/v2/subprotocols/mining/Cargo.toml Outdated Show resolved Hide resolved
protocols/v2/sv2-ffi/Cargo.toml Outdated Show resolved Hide resolved
@GitGab19 GitGab19 linked an issue Dec 16, 2024 that may be closed by this pull request
Crates were not bumped in PR #1230 #1275
Closed
@plebhash plebhash force-pushed the semver-checks-37 branch 4 times, most recently from 03312c2 to 0d6e7f3 Compare December 17, 2024 09:37
@plebhash plebhash force-pushed the semver-checks-37 branch 2 times, most recently from 9a05fc5 to 5d68ca6 Compare December 17, 2024 12:18
@plebhash
lock semver-checks to 37 while replacing MSRV with stable
217de0e
@plebhash
bump serde_v2 major to 2.0.0..
61039ba 
since v37, cargo semver-checks enforces that removal of features are breaking changes

therefore we need to update serde_v2 as a follow up to stratum-mining#1230
@plebhash
bump binary_sv2 for serde_sv2 dependency..
e15fbb9 
since we bumpbed serde_sv2 to 2.0.0
@plebhash
bump sv2_ffi for serde_sv2 dependency..
af34e4b 
since we bumpted serde_sv2 to 2.0.0
@plebhash
bump roles/Cargo.lock..
2b4dcce 
since we bumped serde_sv2 and binary_sv2
@plebhash
bump const_sv2 major to 3.0.0..
0a23c50 
since v37, cargo semver-checks enforces that removal of features are breaking changes

therefore we need to update serde_v2 as a follow up to stratum-mining#1230
@plebhash
bump noise_sv2 for const_sv2 dependency..
c64f423 
since we bumpbed const_sv2 to 3.0.0
@plebhash
bump framing_sv2 for const_sv2 dependency..
4eb7bbc 
since we bumpbed const_sv2 to 3.0.0
@plebhash
bump codec_sv2 for const_sv2 dependency..
13b9c9a 
since we bumpbed const_sv2 to 3.0.0
@plebhash
bump subprotocols for const_sv2 dependency..
d12676c 
since we bumpbed const_sv2 to 3.0.0
@plebhash
bump sv2_ffi for const_sv2 dependency..
2961beb 
since we bumpbed const_sv2 to 3.0.0
@plebhash
bump roles_logic_sv2 for const_sv2 dependency..
e550e89 
since we bumpbed const_sv2 to 3.0.0
@plebhash
bump roles due to const_sv2 bump to 3.0.0
550f1b9
@plebhash
bump framing_sv2 major to 3.0.0..
9c1facf 
since v37, cargo semver-checks enforces that removal of features are breaking changes

therefore we need to update framing_v2 as a follow up to stratum-mining#1230
@plebhash
bump codec_sv2 for framing_sv2 dependency..
26e8d08 
since we bumped framing_sv2 to 3.0.0
@plebhash
bump framing_sv2 dendency version on roles_logic_sv2..
4afe83f 
crate version has already been bumped before release. no need to bump again
@plebhash
bump roles due to framing_sv2 bump
3518efc
@plebhash
bump benches due to framing_sv2 bump
d7b6aac
@plebhash
bump message_generator_sv2 due to const_sv2
a4f8c43
@plebhash plebhash merged commit bf68d8e into stratum-mining:main Dec 18, 2024
37 checks passed
@plebhash plebhash deleted the semver-checks-37 branch December 18, 2024 03:40
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 18, 2024
@plebhash
bump buffer_sv2..
d967790 
as a follow up to stratum-mining#1230 and stratum-mining#1300
This was referenced Dec 18, 2024
Merged
Closed
plebhash added a commit to plebhash/stratum that referenced this pull request Dec 18, 2024
@plebhash
bump buffer_sv2..
f52b8d9 
as a follow up to stratum-mining#1230 and stratum-mining#1300
@plebhash plebhash mentioned this pull request Dec 18, 2024
Merged
@plebhash plebhash added the version-bump version bump for release management label Dec 18, 2024
@plebhash plebhash mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
version-bump version bump for release management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crates were not bumped in PR #1230
2 participants
@plebhash @GitGab19