feat: update ProxyConfig in roles to JDCConfig, and update the references #1316
+85
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
=======================================
Coverage 19.29% 19.29%
=======================================
Files 164 164
Lines 10852 10852
=======================================
Hits 2094 2094
Misses 8758 8758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Bencher Report| Branch | feature/updateProxyConfigName |
| Testbed | sv2 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| client_sv2_open_channel_serialize_deserialize | L2 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 90.00 (+19.25%) | 89.76 (100.27%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result 1e3 x estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2.16 (+2.49%) | 2.23 (96.86%) | 📈 view plot 🚷 view threshold | 473.00 (-0.09%) | 490.93 (96.35%) | 📈 view plot 🚷 view threshold | 733.00 (-0.40%) | 759.92 (96.46%) | 📈 view plot 🚷 view threshold | 6.00 (+20.57%) | 11.99 (50.03%) | 📈 view plot 🚷 view threshold | 40.00 (+3.73%) | 41.64 (96.07%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8.32 (+1.22%) | 8.39 (99.21%) | 📈 view plot 🚷 view threshold | 2,137.00 (-0.00%) | 2,139.44 (99.89%) | 📈 view plot 🚷 view threshold | 3,152.00 (-0.22%) | 3,168.66 (99.47%) | 📈 view plot 🚷 view threshold | 40.00 (+12.45%) | 41.95 (95.35%) | 📈 view plot 🚷 view threshold | 142.00 (+1.75%) | 144.18 (98.49%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6.39 (+1.47%) | 6.44 (99.17%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.03%) | 1,767.95 (98.98%) | 📈 view plot 🚷 view threshold | 2,546.00 (-0.23%) | 2,576.36 (98.82%) | 📈 view plot 🚷 view threshold | 20.00 (+16.68%) | 24.57 (81.40%) | 📈 view plot 🚷 view threshold | 107.00 (+2.30%) | 108.64 (98.49%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14.83 (+0.72%) | 14.93 (99.32%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.01%) | 4,711.95 (99.62%) | 📈 view plot 🚷 view threshold | 6,743.00 (-0.20%) | 6,786.81 (99.35%) | 📈 view plot 🚷 view threshold | 56.00 (+24.27%) | 61.67 (90.81%) | 📈 view plot 🚷 view threshold | 223.00 (+0.83%) | 226.18 (98.59%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 27.85 (+0.94%) | 28.02 (99.39%) | 📈 view plot 🚷 view threshold | 10,645.00 (+0.39%) | 10,690.93 (99.57%) | 📈 view plot 🚷 view threshold | 15,496.00 (+0.40%) | 15,580.19 (99.46%) | 📈 view plot 🚷 view threshold | 97.00 (+16.33%) | 98.97 (98.01%) | 📈 view plot 🚷 view threshold | 339.00 (+1.10%) | 342.49 (98.98%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4.53 (+3.00%) | 4.56 (99.20%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.03%) | 1,478.93 (98.79%) | 📈 view plot 🚷 view threshold | 2,152.00 (-0.40%) | 2,185.35 (98.47%) | 📈 view plot 🚷 view threshold | 13.00 (+60.00%) | 14.05 (92.49%) | 📈 view plot 🚷 view threshold | 66.00 (+5.30%) | 67.24 (98.15%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14.16 (+1.00%) | 14.20 (99.74%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.01%) | 5,081.93 (99.65%) | 📈 view plot 🚷 view threshold | 7,313.00 (-0.18%) | 7,353.08 (99.45%) | 📈 view plot 🚷 view threshold | 46.00 (+27.25%) | 47.78 (96.28%) | 📈 view plot 🚷 view threshold | 189.00 (+1.60%) | 190.93 (98.99%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22.88 (+0.83%) | 23.01 (99.42%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.11%) | 8,056.59 (99.79%) | 📈 view plot 🚷 view threshold | 11,683.00 (-0.01%) | 11,713.72 (99.74%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 90.00 (+19.25%) | 89.76 (100.27%) | 📈 view plot 🚷 view threshold | 307.00 (+1.09%) | 311.23 (98.64%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4.75 (+1.29%) | 4.79 (99.16%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.03%) | 1,519.93 (98.82%) | 📈 view plot 🚷 view threshold | 2,274.00 (-0.20%) | 2,301.78 (98.79%) | 📈 view plot 🚷 view threshold | 12.00 (+27.15%) | 15.58 (77.01%) | 📈 view plot 🚷 view threshold | 69.00 (+2.21%) | 70.06 (98.48%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16.29 (+0.89%) | 16.31 (99.87%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.01%) | 5,980.93 (99.70%) | 📈 view plot 🚷 view threshold | 8,649.00 (-0.18%) | 8,692.93 (99.49%) | 📈 view plot 🚷 view threshold | 52.00 (+29.77%) | 54.75 (94.98%) | 📈 view plot 🚷 view threshold | 211.00 (+1.36%) | 212.00 (99.53%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 35.83 (+0.67%) | 35.92 (99.75%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.15%) | 14,915.48 (99.82%) | 📈 view plot 🚷 view threshold | 21,863.00 (+0.10%) | 21,914.19 (99.77%) | 📈 view plot 🚷 view threshold | 112.00 (+19.84%) | 117.69 (95.17%) | 📈 view plot 🚷 view threshold | 383.00 (+0.93%) | 385.23 (99.42%) |
|
| Branch | feature/updateProxyConfigName |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result 1e3 x estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result 1e3 x instructions (Result Δ%) | Upper Boundary 1e3 x instructions (Limit %) | L1 Accesses | Benchmark Result 1e3 x accesses (Result Δ%) | Upper Boundary 1e3 x accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8.38 (-0.86%) | 8.67 (96.63%) | 📈 view plot 🚷 view threshold | 3.66 (-1.80%) | 3.86 (94.87%) | 📈 view plot 🚷 view threshold | 5.11 (-2.16%) | 5.45 (93.84%) | 📈 view plot 🚷 view threshold | 10.00 (+22.02%) | 15.64 (63.94%) | 📈 view plot 🚷 view threshold | 92.00 (+0.97%) | 96.15 (95.69%) |
| get_submit | 📈 view plot 🚷 view threshold | 95.29 (-0.08%) | 95.65 (99.62%) | 📈 view plot 🚷 view threshold | 59.26 (-0.25%) | 59.70 (99.26%) | 📈 view plot 🚷 view threshold | 85.08 (-0.30%) | 85.81 (99.14%) | 📈 view plot 🚷 view threshold | 47.00 (+5.95%) | 59.86 (78.51%) | 📈 view plot 🚷 view threshold | 285.00 (+1.66%) | 290.32 (98.17%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7.90 (-1.29%) | 8.23 (95.90%) | 📈 view plot 🚷 view threshold | 2.76 (-2.11%) | 2.94 (93.70%) | 📈 view plot 🚷 view threshold | 3.83 (-2.54%) | 4.14 (92.48%) | 📈 view plot 🚷 view threshold | 15.00 (+22.06%) | 20.36 (73.69%) | 📈 view plot 🚷 view threshold | 114.00 (-0.42%) | 117.78 (96.79%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12.17 (-0.73%) | 12.51 (97.30%) | 📈 view plot 🚷 view threshold | 5.24 (-1.19%) | 5.43 (96.57%) | 📈 view plot 🚷 view threshold | 7.28 (-1.47%) | 7.60 (95.77%) | 📈 view plot 🚷 view threshold | 12.00 (+20.19%) | 18.51 (64.84%) | 📈 view plot 🚷 view threshold | 138.00 (+0.18%) | 142.39 (96.92%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24.57 (-0.58%) | 25.18 (97.56%) | 📈 view plot 🚷 view threshold | 9.79 (-0.78%) | 10.01 (97.74%) | 📈 view plot 🚷 view threshold | 13.79 (-0.94%) | 14.17 (97.28%) | 📈 view plot 🚷 view threshold | 35.00 (-2.12%) | 45.63 (76.71%) | 📈 view plot 🚷 view threshold | 303.00 (-0.09%) | 313.03 (96.79%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30.16 (-0.55%) | 30.73 (98.16%) | 📈 view plot 🚷 view threshold | 11.99 (-0.55%) | 12.19 (98.37%) | 📈 view plot 🚷 view threshold | 16.95 (-0.67%) | 17.30 (98.02%) | 📈 view plot 🚷 view threshold | 58.00 (+4.11%) | 67.17 (86.35%) | 📈 view plot 🚷 view threshold | 369.00 (-0.49%) | 379.12 (97.33%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126.43 (-0.01%) | 126.78 (99.73%) | 📈 view plot 🚷 view threshold | 73.12 (-0.19%) | 73.53 (99.44%) | 📈 view plot 🚷 view threshold | 104.76 (-0.24%) | 105.49 (99.30%) | 📈 view plot 🚷 view threshold | 114.00 (+7.36%) | 125.43 (90.89%) | 📈 view plot 🚷 view threshold | 603.00 (+0.95%) | 608.35 (99.12%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27.79 (-0.43%) | 28.40 (97.85%) | 📈 view plot 🚷 view threshold | 9.58 (-0.61%) | 9.76 (98.13%) | 📈 view plot 🚷 view threshold | 13.52 (-0.75%) | 13.84 (97.72%) | 📈 view plot 🚷 view threshold | 68.00 (+5.70%) | 77.49 (87.75%) | 📈 view plot 🚷 view threshold | 398.00 (-0.26%) | 410.09 (97.05%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115.14 (-0.09%) | 115.71 (99.51%) | 📈 view plot 🚷 view threshold | 67.89 (-0.25%) | 68.41 (99.24%) | 📈 view plot 🚷 view threshold | 97.36 (-0.32%) | 98.27 (99.07%) | 📈 view plot 🚷 view threshold | 70.00 (+8.40%) | 85.83 (81.55%) | 📈 view plot 🚷 view threshold | 498.00 (+1.05%) | 502.08 (99.19%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 23.17 (-0.65%) | 23.83 (97.25%) | 📈 view plot 🚷 view threshold | 8.13 (-0.75%) | 8.32 (97.76%) | 📈 view plot 🚷 view threshold | 11.43 (-0.89%) | 11.74 (97.30%) | 📈 view plot 🚷 view threshold | 39.00 (+0.93%) | 50.39 (77.40%) | 📈 view plot 🚷 view threshold | 330.00 (-0.43%) | 342.50 (96.35%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99.75 (-0.04%) | 100.11 (99.64%) | 📈 view plot 🚷 view threshold | 61.33 (-0.23%) | 61.73 (99.34%) | 📈 view plot 🚷 view threshold | 87.93 (-0.28%) | 88.64 (99.20%) | 📈 view plot 🚷 view threshold | 53.00 (+11.34%) | 66.04 (80.26%) | 📈 view plot 🚷 view threshold | 330.00 (+1.53%) | 335.67 (98.31%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11.38 (-0.20%) | 11.60 (98.09%) | 📈 view plot 🚷 view threshold | 4.11 (-1.33%) | 4.28 (95.97%) | 📈 view plot 🚷 view threshold | 5.69 (-1.70%) | 6.00 (94.90%) | 📈 view plot 🚷 view threshold | 17.00 (+25.20%) | 23.34 (72.83%) | 📈 view plot 🚷 view threshold | 160.00 (+1.06%) | 163.61 (97.80%) |
|
| Branch | feature/updateProxyConfigName |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,386.90 (-2.89%) | 6,931.69 (92.14%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,312.70 (-1.51%) | 7,830.60 (93.39%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 7,976.80 (-1.46%) | 9,227.65 (86.44%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 864.12 (-0.31%) | 938.23 (92.10%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 674.89 (+0.08%) | 716.76 (94.16%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 250.71 (+0.55%) | 269.55 (93.01%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 156.10 (-0.84%) | 165.90 (94.09%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,217.90 (-2.08%) | 6,780.98 (91.70%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 280.40 (-0.62%) | 322.18 (87.03%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 727.46 (-0.03%) | 774.65 (93.91%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 598.16 (+1.37%) | 625.73 (95.59%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 205.65 (-0.29%) | 223.03 (92.21%) |
jbesraa
suggested changes
Dec 23, 2024
There was a problem hiding this comment.
Thanks for working on this!
Please go to all of the main.rs files inside roles/[role_name] and there you can that each different role have its own config. We should change the name in each role to reflect the name of the role. For example, in translator role we should change to TranslatorConfig, in jd-server role we should change to JDSConfig and so on.
got it! |
jbesraa
suggested changes
Jan 9, 2025
There was a problem hiding this comment.
Let me just explain a bit about the project structure. You have the roles folder which is a cargo workspace, i.e. it contains multiple crates. Each one of the crates have it is own configuration object. For example, the translator role under roles/translator have the roles/translator/src/lib/proxy_config.rs config. This config should be changed to TranslatorConfig.
Whats correct for the translator is correct for all the other roles. We have jd-client and its config should be JDCConfig. We also have jd-server and its config should be JDSConfig and so on.
Let me know if that is not clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i not found another object with Config, so i changed only ProxyConfig, to check if is what was wanted.
Issue: #1260