Remove protocol deps from pool crate
#1483
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
- Coverage 28.50% 18.76% -9.75%
==========================================
Files 74 135 +61
Lines 5297 9578 +4281
==========================================
+ Hits 1510 1797 +287
- Misses 3787 7781 +3994
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| pub use binary_sv2::Error as BinaryError; | ||
| pub use binary_sv2::U256; | ||
| pub use binary_sv2::B064K; | ||
| pub use binary_sv2::B0255; | ||
|
|
||
| pub use codec_sv2::Error as CodecError; | ||
| pub use codec_sv2::framing_sv2::Error as FramingError; | ||
|
|
||
| pub use codec_sv2::Initiator; | ||
| pub use codec_sv2::Responder; | ||
| pub use codec_sv2::HandshakeRole; | ||
| pub use codec_sv2::noise_sv2::Error as NoiseError; | ||
|
|
||
| pub use codec_sv2::StandardEitherFrame; | ||
| pub use codec_sv2::StandardSv2Frame; | ||
|
|
||
| pub use const_sv2::MESSAGE_TYPE_CHANNEL_ENDPOINT_CHANGED; | ||
|
|
There was a problem hiding this comment.
I have a slightly different opinion on this—let me know what you think. Although roles-logic-sv2 is part of the protocol, it should have been placed in roles, considering that it primarily contains application-layer logic. The codec crate is the protocol crate, encapsulating lower-level foundational crates like binary, framing, noise, and const. To me, it makes sense to expose these from codec and then use them in roles-logic-sv2. That way, the hierarchy remains structured correctly.
There was a problem hiding this comment.
Yea I agree with you. But roles logic is not part of the scope for this pr..
There was a problem hiding this comment.
referenced #1268 (comment)
jbesraa
force-pushed
the
2025-02-13/organise-deps-list
branch
from
59e0e20 to
3fc68a9
Compare
jbesraa
force-pushed
the
2025-02-13/organise-deps-list
branch
from
aa0446d to
b582577
Compare
|
This is ready for review |
jbesraa
force-pushed
the
2025-02-13/organise-deps-list
branch
from
3866fbe to
cb925ea
Compare
This also exports the needed structs/fns through `roles-logic-sv2`.
jbesraa
force-pushed
the
2025-02-13/organise-deps-list
branch
from
cb925ea to
ef80814
Compare
Partially addresses #1458
Blocked by #1483