Ask missing txs #648
Merged
Ask missing txs #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the function handle_declare_mining_job of ParseClientJobDeclarationMessages for the JDserver now responds with DeclareJobDeclarationMessages if all the transactions are recognized, and with ProvideMissingTransaction otherwise
in the handler of ProvideMissingTransaction, the transactions are not decoded and it is left a todo. Once did this, the JDS is able to 1. compare the DeclareMiningJob with the mempool 2. see if there are some missing transactions, and ask for them to the JDclient
lorbax
force-pushed
the
ask_missing_txs
branch
from
70499eb
to
72e9449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.