RequestTransactionDataError better management in JDC#754
Merged
GitGab19 merged 6 commits intostratum-mining:mainfrom Feb 16, 2024
Merged
RequestTransactionDataError better management in JDC#754GitGab19 merged 6 commits intostratum-mining:mainfrom
GitGab19 merged 6 commits intostratum-mining:mainfrom
Conversation
Contributor
|
| Report | Fri, February 16, 2024 at 11:08:28 UTC |
| Project | Stratum v2 (SRI) |
| Branch | fix-request-tx-data-error |
| Testbed | sv1 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Instructions | Instructions Results instructions | (Δ%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | ✅ (view plot) | 8546.000 | ✅ (view plot) | 3746.000 | ✅ (view plot) | 5246.000 | ✅ (view plot) | 9.000 | ✅ (view plot) | 93.000 |
| get_submit | ✅ (view plot) | 95605.000 | ✅ (view plot) | 59439.000 | ✅ (view plot) | 85350.000 | ✅ (view plot) | 56.000 | ✅ (view plot) | 285.000 |
| get_subscribe | ✅ (view plot) | 7999.000 | ✅ (view plot) | 2841.000 | ✅ (view plot) | 3969.000 | ✅ (view plot) | 15.000 | ✅ (view plot) | 113.000 |
| serialize_authorize | ✅ (view plot) | 12269.000 | ✅ (view plot) | 5317.000 | ✅ (view plot) | 7409.000 | ✅ (view plot) | 13.000 | ✅ (view plot) | 137.000 |
| serialize_deserialize_authorize | ✅ (view plot) | 24498.000 | ✅ (view plot) | 9898.000 | ✅ (view plot) | 13958.000 | ✅ (view plot) | 36.000 | ✅ (view plot) | 296.000 |
| serialize_deserialize_handle_authorize | ✅ (view plot) | 30213.000 | ✅ (view plot) | 12101.000 | ✅ (view plot) | 17123.000 | ✅ (view plot) | 56.000 | ✅ (view plot) | 366.000 |
| serialize_deserialize_handle_submit | ✅ (view plot) | 126406.000 | ✅ (view plot) | 73224.000 | ✅ (view plot) | 104946.000 | ✅ (view plot) | 120.000 | ✅ (view plot) | 596.000 |
| serialize_deserialize_handle_subscribe | ✅ (view plot) | 27451.000 | ✅ (view plot) | 9643.000 | ✅ (view plot) | 13636.000 | ✅ (view plot) | 68.000 | ✅ (view plot) | 385.000 |
| serialize_deserialize_submit | ✅ (view plot) | 115027.000 | ✅ (view plot) | 68001.000 | ✅ (view plot) | 97552.000 | ✅ (view plot) | 72.000 | ✅ (view plot) | 489.000 |
| serialize_deserialize_subscribe | ✅ (view plot) | 22832.000 | ✅ (view plot) | 8195.000 | ✅ (view plot) | 11542.000 | ✅ (view plot) | 39.000 | ✅ (view plot) | 317.000 |
| serialize_submit | ✅ (view plot) | 99888.000 | ✅ (view plot) | 61483.000 | ✅ (view plot) | 88198.000 | ✅ (view plot) | 56.000 | ✅ (view plot) | 326.000 |
| serialize_subscribe | ✅ (view plot) | 11294.000 | ✅ (view plot) | 4188.000 | ✅ (view plot) | 5829.000 | ✅ (view plot) | 15.000 | ✅ (view plot) | 154.000 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Fri, February 16, 2024 at 11:08:29 UTC |
| Project | Stratum v2 (SRI) |
| Branch | fix-request-tx-data-error |
| Testbed | sv2 |
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) |
|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 44.144 |
| client_sv2_handle_message_mining | ✅ (view plot) | 64.975 |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.657 |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 266.780 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 582.020 |
| client_sv2_open_channel | ✅ (view plot) | 162.500 |
| client_sv2_open_channel_serialize | ✅ (view plot) | 292.580 |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 367.780 |
| client_sv2_setup_connection | ✅ (view plot) | 164.790 |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 459.970 |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 996.430 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Fri, February 16, 2024 at 11:08:31 UTC |
| Project | Stratum v2 (SRI) |
| Branch | fix-request-tx-data-error |
| Testbed | sv1 |
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) |
|---|---|---|
| client-submit-serialize | ✅ (view plot) | 6675.500 |
| client-submit-serialize-deserialize | ✅ (view plot) | 7583.900 |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 8129.600 |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 895.700 |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 711.290 |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 247.350 |
| client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 156.820 |
| client-sv1-get-submit | ✅ (view plot) | 6535.000 |
| client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 280.320 |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | ✅ (view plot) | 738.200 |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | ✅ (view plot) | 624.670 |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 208.280 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Contributor
|
| Report | Fri, February 16, 2024 at 11:08:29 UTC |
| Project | Stratum v2 (SRI) |
| Branch | fix-request-tx-data-error |
| Testbed | sv2 |
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Instructions | Instructions Results instructions | (Δ%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 2025.000 | ✅ (view plot) | 469.000 | ✅ (view plot) | 730.000 | ✅ (view plot) | 7.000 | ✅ (view plot) | 36.000 |
| client_sv2_handle_message_mining | ✅ (view plot) | 8155.000 | ✅ (view plot) | 2075.000 | ✅ (view plot) | 3055.000 | ✅ (view plot) | 47.000 | ✅ (view plot) | 139.000 |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 6440.000 | ✅ (view plot) | 1750.000 | ✅ (view plot) | 2545.000 | ✅ (view plot) | 23.000 | ✅ (view plot) | 108.000 |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14703.000 | ✅ (view plot) | 4694.000 | ✅ (view plot) | 6748.000 | ✅ (view plot) | 58.000 | ✅ (view plot) | 219.000 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27378.000 | ✅ (view plot) | 10537.000 | ✅ (view plot) | 15328.000 | ✅ (view plot) | 93.000 | ✅ (view plot) | 331.000 |
| client_sv2_open_channel | ✅ (view plot) | 4523.000 | ✅ (view plot) | 1461.000 | ✅ (view plot) | 2153.000 | ✅ (view plot) | 12.000 | ✅ (view plot) | 66.000 |
| client_sv2_open_channel_serialize | ✅ (view plot) | 14010.000 | ✅ (view plot) | 5064.000 | ✅ (view plot) | 7320.000 | ✅ (view plot) | 43.000 | ✅ (view plot) | 185.000 |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22414.000 | ✅ (view plot) | 7979.000 | ✅ (view plot) | 11614.000 | ✅ (view plot) | 74.000 | ✅ (view plot) | 298.000 |
| client_sv2_setup_connection | ✅ (view plot) | 4719.000 | ✅ (view plot) | 1502.000 | ✅ (view plot) | 2274.000 | ✅ (view plot) | 13.000 | ✅ (view plot) | 68.000 |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 16112.000 | ✅ (view plot) | 5963.000 | ✅ (view plot) | 8657.000 | ✅ (view plot) | 49.000 | ✅ (view plot) | 206.000 |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35420.000 | ✅ (view plot) | 14806.000 | ✅ (view plot) | 21745.000 | ✅ (view plot) | 103.000 | ✅ (view plot) | 376.000 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Fi3
reviewed
Feb 15, 2024
Collaborator
There was a problem hiding this comment.
since we match string here would be useful to log which is the string that is not parsable. So i suggest to use somthing like Error::NoValidTemplate(error-message)
GitGab19
force-pushed
the
fix-request-tx-data-error
branch
from
ed82b7c to
e364d9f
Compare
Collaborator
|
Code looks reasonable to me, but I haven't tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #709