Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mg GitHub actions more stable moving compilation before running tests #867

Closed
wants to merge 3 commits into from
Closed

Make mg GitHub actions more stable moving compilation before running tests #867

wants to merge 3 commits into from

Conversation

lorbax
Copy link
Collaborator

@lorbax lorbax commented Apr 23, 2024

In the message-generator.sh script the binaries are pre-compiled so that the MG-tests do not take forever for run, reducing probability of timeouts

@Fi3
Copy link
Collaborator

Fi3 commented Apr 23, 2024

I noticed that you added llvm-cov everywhere can you explain what it do and why il called with --no-report? Also having it documented somewhere in the project would be nice. Ty

@lorbax
Copy link
Collaborator Author

lorbax commented Apr 23, 2024

I noticed that you added llvm-cov everywhere can you explain what it do and why il called with --no-report? Also having it documented somewhere in the project would be nice. Ty

Hi you are actually right. It is called with --no-report everywhere except here. I am not practical with llvm-cov and I don't know if and when we need it. I used llvm-cov everywhere in order to use the same binaries, avoiding recompiling whenever possible.

@Fi3
Copy link
Collaborator

Fi3 commented Apr 23, 2024

Hi you are actually right. It is called with --no-report everywhere except here. I am not practical with llvm-cov and I don't know if and when we need it. I used llvm-cov everywhere in order to use the same binaries, avoiding recompiling whenever possible.

@lorbax ok since no one is practical with it I think that we should add some documentation about it in this PR and justify why we use it.

@lorbax
Copy link
Collaborator Author

lorbax commented Apr 23, 2024

Hi you are actually right. It is called with --no-report everywhere except here. I am not practical with llvm-cov and I don't know if and when we need it. I used llvm-cov everywhere in order to use the same binaries, avoiding recompiling whenever possible.

@lorbax ok since no one is practical with it I think that we should add some documentation about it in this PR and justify why we use it.

I will spend some time with it and understand what should we do with it.

@lorbax lorbax force-pushed the make-MG-github-actions-more-stable branch 3 times, most recently from c8518af to 799bdbe Compare April 30, 2024 13:45
@pavlenex pavlenex mentioned this pull request May 1, 2024
Closed
@pavlenex pavlenex added this to the 1.0.1 milestone May 1, 2024
@Fi3 Fi3 deleted the branch stratum-mining:dev May 3, 2024 09:37
@Fi3 Fi3 closed this May 3, 2024
@Fi3 Fi3 reopened this May 3, 2024
@Fi3
Copy link
Collaborator

Fi3 commented May 3, 2024

This PR needs to be rebased on dev

@lorbax lorbax force-pushed the make-MG-github-actions-more-stable branch from 799bdbe to 570a6ff Compare May 3, 2024 15:04
lorbax added 3 commits May 3, 2024 17:14
@lorbax
Make MG script to build before launching tests
7123a99 
With this modification, the binaries are built before launching any
MG-test, making them run quicker and less likely to encounter a timeout.
This should make the MG-tests a bit more stable
@lorbax
Fix tests
36bbab7 
Whenever possible, in the tests we launch application in such a way that
the same binaries are used, in order to avoid compilation during MG
tests running
@lorbax
fix main and fmt
634da05
@lorbax lorbax force-pushed the make-MG-github-actions-more-stable branch from a408a50 to 634da05 Compare May 3, 2024 15:19
plebhash
plebhash reviewed May 9, 2024
View reviewed changes
message-generator-tests.sh
for entry in `ls $search_dir`; do
if [ "$entry" = "interop-jdc-change-upstream.json" ]; then
echo "Skipping $entry"
continue
fi

sleep 10
Copy link
Collaborator

@plebhash plebhash May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment explaining this sleep?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order to give time to every process to close successfully

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my suggestion was to add a comment to the shell script

@lorbax lorbax closed this May 14, 2024
@lorbax
Copy link
Collaborator Author

lorbax commented May 27, 2024

replaced by #905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash left review comments

Assignees

@lorbax lorbax

Labels
None yet
Projects
SV2 Roadmap 🛣️
Status: Done ✅
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lorbax @Fi3 @plebhash @pavlenex