extensions-negotiation definition
#112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
concept ack |
TheBlueMatt
reviewed
Dec 5, 2024
|
@Fi3 @TheBlueMatt @jakubtrnka this PR is ready for review |
|
@Fi3 just a reminder to approve this, as we agreed during yesterday's call |
Fi3
reviewed
Dec 18, 2024
jbesraa
reviewed
Dec 18, 2024
GitGab19
force-pushed
the
extensions-negotiation
branch
from
c6f28d9 to
590457b
Compare
jbesraa
reviewed
Feb 4, 2025
Shourya742
reviewed
Feb 24, 2025
There was a problem hiding this comment.
I'm just curious—Is the primary reason for not adding another field to the setup connection message and instead introducing an entirely new message exchange to ensure that, in case of an error (such as one party not supporting a particular extension), the connection remains open? This way, the client can modify the extension set and resend the extension request rather than having the connection closed.
TheBlueMatt
reviewed
Feb 27, 2025
GitGab19
force-pushed
the
extensions-negotiation
branch
from
590457b to
6fc0770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines extension n.1 which allows for any implementation to support future extensions in a clean and scalable way.
Close #111