Use getCoinbase() if available #59
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents repeating calls to getBlockHeader()
Avoid the brittle process of constructing the template coinbase fields from Bitcoin Core's dummy coinbase transaction. This uses the new getCoinbase() interface method. Fall back to the old approach if that method is not available.
Sjors
force-pushed
the
2025/11/coinbase
branch
from
b31cc6c to
a0d4a73
Compare
Collaborator
Author
|
Rebased after #57 and bumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of the new
getCoinbase()introduced in bitcoin/bitcoin#33819 which provides aCoinbaseTemplatestruct.This lets us avoid parsing Bitcoin Core's dummy transaction. For backwards compatibility the
ExtractCoinbaseTemplatestill does that. This can be dropped after a Bitcoin Core release ships with the new method.Builds on: