Don't add SSL when accessing via a Tor domain name

[TheFiZi]

I'm using this plugin to get my blog working as a Tor hidden service. My site is available via it's normal URL and a tor service URL.

The base domain is: https://www.pickysysadmin.ca/ and Wordpress enforces SSL

This is my configuration for the plugin:

When I go to http://27i7rsfkhoanzabw.onion/ the initial page load is fine. When I click on any internal links to the site the URL is re-written to https://27i7rsfkhoanzabw.onion/ which doesn't work in Tor land.

A potential solution to this would be to have the plugin always drop/not add SSL on domains that end in .onion when re-writing the URLs.

[straube]

@TheFiZi I'm wondering if it makes sense to have this exception hard-coded.

I may add a new option for when adding a domain:

[ Name ][ Protocol (Auto, Force HTTP, or Force HTTPS) ][ Base path ][ Locale ]

I think that makes more sense and covers more cases where users want to force a given protocol. What do you think?

In any way, I only will have time to work on this change in 2-3 weeks.

[TheFiZi]

@straube That sounds like a good way to handle it to me.

[straube]

I started working on this. I had a discussion with our UX designer and we'll improve the usability of the plugin configuration section.

[straube]

@TheFiZi I added the protocol option to domain settings. Please update the plugin in your WP installation to 0.10.0 and set the protocol option for 27i7rsfkhoanzabw.onion to http://. Let me know if that fixes the issue.

[TheFiZi]

Hmmm. I don't think it's re-writing the URLs at all now.

[straube]

Could you send me a screenshot of your current plugin setup?

…

On 8 Mar 2019, at 20:04, Eric ***@***.***> wrote: Hmmm. I don't think it's re-writing the URLs at all now. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[TheFiZi]

Here you go:

[straube]

I just pushed an update (0.10.2) to fix that. Until 0.9.x, you were not required to include the original domain where you installed WordPress into the plugin settings. However, in 0.10.0 this is mandatory. That requirement broke some installations. I added a fallback to the plugin always load the original domain. Which is www.pickysysadmin.ca in your case, right?

Please keep me posted about any remaining issues.

[TheFiZi]

Looks like that patch did the trick and got us 98% there.

Post patch:

After loading up the site in Tor:

Looks like only two images aren't having their URLs re-written. Those two images are linked inside a Widget block:

That link to the "tip jar" is also not being re-written (pictured above): <p><a title="More ways to tip with crypto" href="https://www.pickysysadmin.ca/the-tip-jar">More ways to tip with crypto</a></p>