Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Image URLs not being re-written properly via Tor #32

Closed
TheFiZi opened this issue Nov 11, 2018 · 5 comments
Closed

Image URLs not being re-written properly via Tor #32

TheFiZi opened this issue Nov 11, 2018 · 5 comments

Comments

@TheFiZi
Copy link

TheFiZi commented Nov 11, 2018

@straube straube added the bug label Nov 13, 2018
@straube
Copy link
Owner

straube commented Nov 13, 2018

@TheFiZi This is definitely a bug. I have almost no free time to work on this around these days. But as soon as I have a chance, I'll write a fix for this. In the meantime, if you find a solution, feel free to submit a PR. :)

@straube straube added this to the 1.0 milestone Nov 13, 2018
@straube
Copy link
Owner

straube commented Dec 14, 2018

@TheFiZi Have you figured out a way to fix this issue? If you haven't, could you help me debug this issue? I need to check how the content looks like before the plugin replaces the URLs. Adding the var_dump call below to line 313 would print out that value:

var_dump($content);

This is just after the following lines:

public function fixContentUrls($content)
{
    if (array_key_exists($this->domain, $this->domains)) {
        // Add the var_dump here

@TheFiZi
Copy link
Author

TheFiZi commented Dec 19, 2018

Sorry for the delay.

I've inserted the code and you can view the results by going to http://27i7rsfkhoanzabw.onion/ via the Tor Browser.

Here is a screenshot of an example. I'm not sure if it's outputting the data you want.

image

@straube
Copy link
Owner

straube commented Dec 19, 2018

@TheFiZi Thanks to your help, I was able to track the bug down.

The issue is now fixed and a new version was released: 0.8.2. Please update it in your Wordpress instance and let me know how it goes.

@TheFiZi
Copy link
Author

TheFiZi commented Dec 20, 2018

@straube I think that's got it fixed. The links all look correct now.

Things still aren't loading properly but that's because of issue #31 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants