Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Missing locales on language list #38

Closed
straube opened this issue Jan 17, 2019 · 6 comments
Closed

Missing locales on language list #38

straube opened this issue Jan 17, 2019 · 6 comments
Assignees

Comments

@straube
Copy link
Owner

straube commented Jan 17, 2019

As reported by Tom, through email:

I've started using your plugin but have trouble finding DE_AT in the list of locales. I figured that your plugin is using the wordpress translation list but that one isn't complete.

I change the value manually in the db but that didn't stick because the plugin didn't pull that new value into the domains list. Any unrelated change on the settings page would thus overwrite my changed setting :(

I believe that using the language list he suggested is the best approach here.

This issue was introduced by #17.

@straube straube self-assigned this Jan 17, 2019
@TomK32
Copy link

TomK32 commented Jan 17, 2019

Thanks, but it seems I've sent you the wrong link, it should be the locales list from this one:

https://github.com/umpirsky/locale-list/blob/master/data/en/locales.csv

As a simple litmus test: It has to be en_GB, not en_UK. https://support.google.com/webmasters/answer/189077?hl=en

@straube
Copy link
Owner Author

straube commented Jan 18, 2019

@TomK32 This was fixed by f1305ba. The latest release (v 0.8.5) includes that update.

Let me know if you find anything wrong with that update.

@straube straube closed this as completed Jan 18, 2019
@TomK32
Copy link

TomK32 commented Jan 18, 2019

Did the format change from de-DE to de_DE or something like that? Getting empty fields here when I load the preferences page. Might confuse a lot of people.

I strongly recommend adding the existing value to the select and no rely on it being in the list.

2019-01-18 19 14 22

@straube
Copy link
Owner Author

straube commented Jan 22, 2019

That sounds like a bug. Reopening the issue...

@straube
Copy link
Owner Author

straube commented Feb 1, 2019

@TomK32 I didn't run all the tests but this commit I referenced above contains a possible fix for this issue. After I do some more testing, I'll release an update through Wordpress' repository.

@straube
Copy link
Owner Author

straube commented Feb 7, 2019

@TomK32 I finally release an update to WP.org that includes the fix I mentioned last week. It's in 0.8.7. Let me know if it fixes the lang selection.

@straube straube closed this as completed Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants