This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Make JavaScript HTTP connection emit timeout event #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript
HttpConnection
allows the caller to set a request timeout via thenodeOptions
property. However, neither the connection object nor the thrift client provides a way for the caller to know when a timeout occured. With this change, theHttpConnection
will now emit a timeout event when an underlying NodeJS timeout event occurs. A caller can add an event listener to the connection as follows: