-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove mention about having to enable subscriptions in the docs #645
Conversation
Reviewer's Guide by SourceryThis pull request removes outdated information from the documentation regarding the need to enable subscriptions, as the feature is now enabled by default. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief note mentioning that subscriptions are now enabled by default, to provide context for the removal of this section and help users upgrading from older versions.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 41 41
Lines 3606 3606
=======================================
Hits 3199 3199
Misses 407 407 ☔ View full report in Codecov by Sentry. |
The subscriptions feature is now enabled by default. Not only that, but the keyword to enable it got removed in https://github.com/strawberry-graphql/strawberry/releases/tag/0.245.0
bd99210
to
5c2b20c
Compare
The subscriptions feature is now enabled by default.
Not only that, but the keyword to enable it got removed in https://github.com/strawberry-graphql/strawberry/releases/tag/0.245.0
Fix #644
Summary by Sourcery
Documentation: