Move Strawberry config to a typed dict #3365
Open
+175
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR aims to change Strawberry's schema config to be a typed dictionary. Then only one import would be required to instantiate the schema.
In the
Schema
class initialization the formerdataclass
is used to handle default values and validations. Then, my approach for this fix was not to remove the old dataclass.UTs were updated accordingly.
Types of Changes
Issues Fixed or Closed by This PR
Checklist