-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused chalice test code #3739
Remove unused chalice test code #3739
Conversation
Reviewer's Guide by SourceryThis PR removes the unused chalice/app.py test file. This test file was unused since we started sharing tests between HTTP integrations. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DoctorJohn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3739 +/- ##
==========================================
- Coverage 97.22% 96.95% -0.27%
==========================================
Files 502 501 -1
Lines 33428 33408 -20
Branches 5484 5480 -4
==========================================
- Hits 32499 32390 -109
- Misses 721 798 +77
- Partials 208 220 +12 |
CodSpeed Performance ReportMerging #3739 will not alter performanceComparing Summary
|
Description
This PR removes Chalice test code that has been unused since we started sharing tests between HTTP integrations.
Types of Changes
Summary by Sourcery
Enhancements: