Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused chalice test code #3739

Merged

Conversation

DoctorJohn
Copy link
Member

@DoctorJohn DoctorJohn commented Dec 24, 2024

Description

This PR removes Chalice test code that has been unused since we started sharing tests between HTTP integrations.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Summary by Sourcery

Enhancements:

  • Removed the unused Chalice test code that was previously used for HTTP integration tests.

Copy link
Contributor

sourcery-ai bot commented Dec 24, 2024

Reviewer's Guide by Sourcery

This PR removes the unused chalice/app.py test file. This test file was unused since we started sharing tests between HTTP integrations.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the unused chalice/app.py test file
  • Deleted the entire file
tests/chalice/app.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DoctorJohn - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (ddfc084) to head (b5a100a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3739      +/-   ##
==========================================
- Coverage   97.22%   96.95%   -0.27%     
==========================================
  Files         502      501       -1     
  Lines       33428    33408      -20     
  Branches     5484     5480       -4     
==========================================
- Hits        32499    32390     -109     
- Misses        721      798      +77     
- Partials      208      220      +12     

Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #3739 will not alter performance

Comparing DoctorJohn:remove-unused-chalice-test-code (b5a100a) with main (bd29cff)

Summary

✅ 21 untouched benchmarks

@patrick91 patrick91 merged commit e78f8c6 into strawberry-graphql:main Dec 24, 2024
84 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants