Clean up StrawberryField and StrawberryArgument interface

[jkimbo]

Description

• Change the signature of StrawberryField to make it easier to instantiate directly (defaulting arguments to None)
• Rename default_value to default in StrawberryField
• Rename default_value to default in StrawberryArgument
• Remove usages of undefined in favour of UNSET (note: I haven't actually removed undefined but I think we can do that now)

These changes are pretty minor but they are the ground work for allowing custom fields. I was just going to do all the changes necessary but #906 changes some of the code I was going to touch so I'll write up my proposal for it first before doing the code changes.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[botberry]

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

---

• Remove usages of undefined in favour of UNSET
• Change the signature of StrawberryField to make it easier to instantiate
  directly. Also change default_value argument to default
• Rename default_value to default in StrawberryArgument

[codecov]

Codecov Report

Merging #916 (eef3359) into main (4fc9c9b) will not change coverage.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          76       76           
  Lines        2592     2592           
  Branches      362      362           
=======================================
  Hits         2525     2525           
  Misses         41       41           
  Partials       26       26           

[BryceBeagle]

Advantage of adding truthiness?

[jkimbo]

I just moved this class around. Not sure what the point of this is. @patrick91 do you know?

[patrick91]

it's to make sure you can use it in if statements:

def something(a: int = UNSET):
    if a:
        return 

    ...

(note this check is silly but it's to demonstrate the idea :) )

[BryceBeagle]

That seems like it could lead to bugs. What if a is 0?

[patrick91]

sorry I missed this comment! that's a good point 😊

but then that means you always need to check if it is unset before doing anything with it, right? I guess that's similar to using None, so I think we can remove it :)

[jkimbo]

BTW UNSET will be changing significantly with this change anyway: #872

[jkimbo]

@patrick91 @BryceBeagle I've added some release notes. I think this is good to go now.

[patrick91]

Looks good to me! There's a couple of comments, but we can merge the PR and deal with them later if you prefer @jkimbo 😊

[patrick91]

sorry I missed this comment! that's a good point 😊

but then that means you always need to check if it is unset before doing anything with it, right? I guess that's similar to using None, so I think we can remove it :)