Changes from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Option for DeepAR and DeepState to allow an embedding vector instead of the same value for all categorical features. By default, if no argument, automatically use the heuristic given by Jermey Howard of fast.Ai [1] Each categorical features with size cat_sz, will be associated with a vector with length defined as below. emb_szs = [(c, min(50, (c+1)//2)) for _, c in cat_sz] By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. [1] https://github.com/fastai/fastai/blob/master/courses/dl1/lesson3-rossman.ipynb * #315 Ran "python setup.py type_check" - passed Ran "black src" for proper formatting * Ensuring embedding dimension is not None
* Fixes for serializing sets and numpy numbers in SerDe * Tests for changes in SerDe. Fixes for JSON and code serializations
* fix flaky sampling test * removing useless import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.