Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add content security policy (csp) to example page #615

Merged
merged 2 commits into from
Mar 2, 2021
Merged

chore: add content security policy (csp) to example page #615

merged 2 commits into from
Mar 2, 2021

Conversation

luqven
Copy link
Contributor

@luqven luqven commented Mar 2, 2021

Changes

This PR adds a CSP to index.html.

This is done to both:

  1. act as a manual check that scripts are not haphazardly altering style attributes so that
  2. its easy for users to reference and or create hashes of the styles to whitelist them in their CSPs.

The changes introduced by this PR build off of a previous discussion around CSP errors and how to best address them.

@luqven luqven requested a review from sherwinski March 2, 2021 00:50
@luqven luqven requested a review from a team as a code owner March 2, 2021 00:50
@luqven luqven self-assigned this Mar 2, 2021
@commit-lint
Copy link

commit-lint bot commented Mar 2, 2021 •
edited
Loading

Chore

  • prettier format index (8f8ece1)
  • add style src CSP to index html (86cb018)

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

frederickfogerty
frederickfogerty reviewed Mar 2, 2021
View reviewed changes
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Base automatically changed from luis/rollbackDomFix to main March 2, 2021 13:18
@luqven luqven force-pushed the luis/addIndexCsp branch from 37ead81 to 86cb018 Compare March 2, 2021 13:20
@luqven luqven merged commit edd3755 into main Mar 2, 2021
@luqven luqven deleted the luis/addIndexCsp branch March 2, 2021 13:23
@sherwinski sherwinski linked an issue Mar 4, 2021 that may be closed by this pull request
Content-Security-Policy blocking inline styles #595
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederickfogerty frederickfogerty frederickfogerty approved these changes

@sherwinski sherwinski Awaiting requested review from sherwinski

Assignees

@luqven luqven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content-Security-Policy blocking inline styles
2 participants
@luqven @frederickfogerty