fix(zoom-pane): set min and max values correctly when image is smaller than container #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederickfogerty
commented
Jul 9, 2018
| @@ -94,31 +115,21 @@ export default class ZoomPane { | |||
| let scrollY = window.pageYOffset; | |||
|
|
|||
| let inlineLeft = | |||
| triggerRect.left + | |||
There was a problem hiding this comment.
These changes are just performance changes, removing calls to this.el.clientWidth (or similar) and replacing them with elWidth, which reduces the number of DOM calls, improving performance
frederickfogerty
commented
Jul 9, 2018
| : differenceBetweenContainerWidthAndImgWidth; | ||
| const maxTop = isContainerLargerThanImgY | ||
| ? differenceBetweenContainerHeightAndImgHeight / 2 | ||
| : differenceBetweenContainerHeightAndImgHeight; |
There was a problem hiding this comment.
These previous lines (99-107) are the only functional changes in this PR, along with updating the conditionals on lines 130 and 136 to use these values
jayeb
approved these changes
Jul 9, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the past there was an issue where if the zoomed image's width was smaller than the width of the zoomed image's container, the image would jump around the container when panning around the image. This is shown here #65.
This PR updates the positioning logic of the zoom pane to ensure that the image is rendered correctly in both situations (when the image is smaller than the container, and when it is bigger).
Bug Fix
fix(<area>): fixed bug #issue-numberSteps to Test