Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows-core requirement from >=0.50, <=0.52 to >=0.50, <=0.53 #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update windows-core requirement from >=0.50, <=0.52 to >=0.50, <=0.53 #128

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 23, 2024 •
edited
Loading

Updates the requirements on windows-core to permit the latest version.

Release notes

Sourced from windows-core's releases.

0.53.0

As requested, this release updates the Windows family of crates. Notably:

  • The windows-sys crate won't be updated at this time.
  • The windows-version crate is unchanged.
  • There is a minor (compatible) update to the windows-targets crates.
  • This is the first release of the windows-result (#2847) crate and provides efficient Windows error handling and propagation with support for Win32, COM, WinRT, and NT APIs.
  • This is the first release of the windows-registry (#2848) crate and provides simple, safe, and efficient access to the Windows registry.
  • VARIANT and PROPVARIANT support has been added to the windows-core crate (#2786), making it a lot easier to work with Shell and OLE APIs.
  • Windows metadata has been updated providing additional APIs and fixes.
  • A new feature search tool is now available to quickly determine which features to enable for a given API. 
  • A number of new tutorials have been added.
  • A number of new samples have been added.
  • Many additional fixes and improvements listed below.

What's Changed

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot
Update windows-core requirement from >=0.50, <=0.52 to >=0.50, <=0.54
6b07c79 
Updates the requirements on [windows-core](https://github.com/microsoft/windows-rs) to permit the latest version.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](microsoft/windows-rs@0.50.0...0.53.0)

---
updated-dependencies:
- dependency-name: windows-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 23, 2024
@astraw astraw changed the title Update windows-core requirement from >=0.50, <=0.52 to >=0.50, <=0.54 Update windows-core requirement from >=0.50, <=0.52 to >=0.50, <=0.53 Feb 24, 2024
@astraw
Copy link
Member

astraw commented Feb 24, 2024

@MarijnS95 you wrote most of the current windows implementation. Would you be able to check what is required to update to windows-core 0.53?

@MarijnS95
Copy link
Contributor

@astraw looks like the files need a regen. I'm still out of the country for little over a week, before I can take a proper look.

@astraw
Copy link
Member

astraw commented Feb 25, 2024

@MarijnS95 thanks for the quick reply. It would be great if you can take a look when you are back.

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 28, 2024

A newer version of windows-core exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@Kijewski
Copy link
Collaborator

Alas, windows-core 0.54 is not backward compatible to 0.52. And the generated code in Windows.rs uses edition 2021 features.

So, we can either

  1. stay with the old windows-core version
  2. edit the generated code
  3. upgrade the whole library to edition 2021
  4. split the windows support into its own crate like we did with haiku.

I don't like the 1st option, because we wouldn't benefit from any upgrades, security fixes, etc. the windows people implement.

I don't like the 2nd option, because it makes us less trustworthy if we ship a metric ton of generated code that cannot be easily diff'd.

I would find option 3 acceptable. It's been over two years since rustc 1.56 was released on 2021-10-21.

But I like option 4 the best, actually. Windows.rs has 10x the size of the other code combined.

What do you think?

@astraw
Copy link
Member

astraw commented Feb 28, 2024

@Kijewski your thoughts sound reasonable and I'd support your approach. I rarely develop on Windows and so it would be great if you and @MarijnS95 could shepherd this through.

@MarijnS95
Copy link
Contributor

@astraw turns out this got lost somewhere in my massive backlog when coming back. It's now done in #131.

I'll open up a PR for windows-core 0.55 and explain why I'm not in favour of using it just yet.

@Kijewski Kijewski added the Tier-1 Rust Tier-1 platform label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Tier-1 Rust Tier-1 platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astraw @MarijnS95 @Kijewski