Downgrade requirements for WASM dependencies #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly support was added in #38 targeting the current versions versions of wasm-bindgen and js-sys at the time, which is reasonable. Unfortunately the whoami crate, in trying to support older Rust versions, has reduced the upper version of wasm-bindgen that it supports, see ardaku/whoami#43.
This PR thus reduces the minimum version required for wasm-bindgen. I used
cargo +nightly update -Z minimal-versions
withcargo build --target wasm32-unknown-unknown
to find the earliest version that compiles. We could theoretically set up checks in CI to verify this on an ongoing basis, but this might be overkill for now.cc @Kijewski