Fix tslint/style issues #1046
Closed
Fix tslint/style issues #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackxored
force-pushed
the
style/fix-tslint
branch
5 times, most recently
from
d5da2d0 to
44eff0f
Compare
|
❌ build failed |
app/components/page-components/Chatbot/shared/ChatbotAliases.vue.ts
Outdated
Show resolved
Hide resolved
blackxored
force-pushed
the
style/fix-tslint
branch
from
44eff0f to
074bd74
Compare
holiber
approved these changes
Nov 29, 2018
blackxored
force-pushed
the
style/fix-tslint
branch
2 times, most recently
from
5e752d7 to
edfdba4
Compare
While the current config is essentially a no-op, we added the style rules, and this commit fixes all of them across our codebase.
Whether or not these are WIP I think it'd be great not to have syntax errors. In addition, now these files are formatted accordingly.
blackxored
force-pushed
the
style/fix-tslint
branch
from
a18e975 to
7d00c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all formatting issues across the codebase. TSLint config was (and remains for now), pretty much style-checks. However, lots of files do not adhere to that, plus the couple of additions I've introduced lately.
This sort of depends on #1043, hence might need rebasing so don't repeat commits.