check stream readable #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
requested changes
Mar 25, 2018
dougwilson
reviewed
Mar 25, 2018
|
Sorry I haven't landed this yet -- it's not because this is not desired, just trying to determine if this is semver major or can land as semver minor. I'm poking it now to see if everything that currently would fail this check just hangs forever, then that sounds semver minor to me 👍 |
This comment was marked as spam.
This comment was marked as spam.
|
@dougwilson were you able to determine if this would be semver major or minor? |
This comment was marked as spam.
This comment was marked as spam.
dougwilson
pushed a commit
to ziyofun/raw-body
that referenced
this pull request
Feb 17, 2022
dougwilson
pushed a commit
to ziyofun/raw-body
that referenced
this pull request
Feb 17, 2022
dougwilson
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for stream in situation #57 ,if the
stream.readableisfalse, there will be an error instead of endless waiting.