Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add The Unlicense license SDPX in package.json #231

Merged
merged 1 commit into from
Apr 1, 2021
Merged

fix: add The Unlicense license SDPX in package.json #231

merged 1 commit into from
Apr 1, 2021

Conversation

SamuelCabralCruz
Copy link
Contributor

@SamuelCabralCruz SamuelCabralCruz commented Mar 31, 2021

closes #230
This is required by our infra tooling to validate the license compliance and allows us to consumed this package.

@SamuelCabralCruz
Copy link
Contributor Author

SamuelCabralCruz commented Apr 1, 2021

@teagrinder @jvasseur @bytesnz @G-Rath @fearthecowboy is it possible to get this in?

@G-Rath
Copy link
Collaborator

G-Rath commented Apr 1, 2021

I don't have access on this repo, so can't help you I'm afraid.

I'll a little surprised your infra tool doesn't access the inclusion of a LICENSE file in the package?

@SamuelCabralCruz
Copy link
Contributor Author

@G-Rath yeah we use d2l-license-checker and it lacks couple of features, but have not found any other good library do you any suggestion? I was surprised that it cannot scan the repo for the LICENSE file as well. there is definitely some improvement to be done there!

@streamich streamich merged commit 0041d22 into streamich:master Apr 1, 2021
@streamich
Copy link
Owner

@G-Rath I've sent you an invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add license
3 participants