Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for functional updates for useLocalStorage #438

Closed
charlax opened this issue Jul 4, 2019 · 2 comments · Fixed by #439
Closed

Add support for functional updates for useLocalStorage #438

charlax opened this issue Jul 4, 2019 · 2 comments · Fixed by #439
Labels
released

Comments

@charlax
Copy link
Contributor

charlax commented Jul 4, 2019

To become a drop-in replacement for useState, useLocalStorage should support functional updates

https://usehooks.com/useLocalStorage/ provides one way to do it.
@charlax
Copy link
Contributor Author

charlax commented Jul 4, 2019

Actually, since it's using setState, it should be just a typescript issue. Let me try to fix.

charlax added a commit to charlax/react-use that referenced this issue Jul 4, 2019
@charlax
Fix useLocalStorage types for functional updates
5f5376c 
Fixes streamich#438
@charlax charlax mentioned this issue Jul 4, 2019
Merged
@streamich
Copy link
Owner

🎉 This issue has been resolved in version 9.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix useLocalStorage types for functional updates charlax/react-use
2 participants
@charlax @streamich