Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update useMedia hook to use recommended approach of MDN #2536

Merged
merged 1 commit into from
Jan 13, 2024
Merged

fix: update useMedia hook to use recommended approach of MDN #2536

merged 1 commit into from
Jan 13, 2024

Conversation

willnguyen1312
Copy link
Contributor

@willnguyen1312 willnguyen1312 commented Jan 10, 2024 •
edited
Loading

Description

As of now, useMedia hook uses addListener which is deprecated. This PR simply updates the current hook to the recommended approach from MDN :)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

streamich
streamich approved these changes Jan 13, 2024
View reviewed changes
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@streamich streamich merged commit 3264d96 into streamich:master Jan 13, 2024
8 checks passed
@streamich
Copy link
Owner

🎉 This PR is included in version 17.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@willnguyen1312 willnguyen1312 deleted the pr/update-use-media branch January 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willnguyen1312 @streamich