-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation block tests #554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
After update to react v16.9 and react-testing-library v9 with improved async stuff for testing, timers work slightly different and need to be set inside act.
# Conflicts: # src/__tests__/useTimeout.test.ts
Belco90
commented
Aug 22, 2019
Belco90
commented
Aug 22, 2019
Belco90
commented
Aug 22, 2019
Belco90
commented
Aug 22, 2019
Belco90
commented
Aug 22, 2019
Belco90
commented
Aug 22, 2019
Belco90
commented
Aug 22, 2019
Belco90
commented
Aug 22, 2019
streamich
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
🎉 This PR is included in version 11.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@Belco90 I've sent you a collab invite. |
Awesome! Thanks for the collab invitation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for animation hooks block #101
This one was hard to test, specially useRaf and useSpring but I learnt a lot testing them!
This include tests for:
The PR also includes some bug fixes!