Skip to content

Commit

Permalink
Seems that waiting for crates.io update is not required anymore
Browse files Browse the repository at this point in the history
Will know for sure only on next release but I'm pretty confident, publishing now yield the message `Waiting on `substreams-ethereum` to propagate to crates.io index (ctrl-c to wait asynchronously)` with a few follow up about `Updating crates.io index` so it seems publish now properly wait to crates.io to be updated properly.
  • Loading branch information
maoueh committed Mar 21, 2023
1 parent f5c400f commit 52408a8
Showing 1 changed file with 0 additions and 26 deletions.
26 changes: 0 additions & 26 deletions bin/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,8 @@ main() {
fi

cargo publish $args --target wasm32-unknown-unknown -p substreams-ethereum-core

maybe_wait_publish
cargo publish $args --target wasm32-unknown-unknown -p substreams-ethereum-abigen

maybe_wait_publish
cargo publish $args --target wasm32-unknown-unknown -p substreams-ethereum-derive

maybe_wait_publish
cargo publish $args --target wasm32-unknown-unknown -p substreams-ethereum
}

Expand Down Expand Up @@ -112,26 +106,6 @@ verify_keybase() {
fi
}

maybe_wait_publish() {
if [[ "$force" == "true" ]]; then
# We must wait a bit in-between publish lettin enough time for the crates.io registry to
# correctly records the newly published crate.
#
# Without this wait time, the second publish can hit `no matching package named ...` errors
# because the dependent crate is not "seen" by the registry yet.
#
# Verifying substreams v0.0.8-beta (/Users/maoueh/work/sf/substreams/rust/substreams)
# error: failed to verify package tarball
#
# Caused by:
# no matching package named `substreams-macro` found
# location searched: registry `crates-io`
# required by package `substreams v0.0.8-beta (/Users/maoueh/work/sf/substreams/target/package/substreams-0.0.8-beta)`
echo "Waiting 30s giving time to crates.io to updates its public registry with new version..."
sleep 30
fi
}

usage_error() {
message="$1"
exit_code="$2"
Expand Down

0 comments on commit 52408a8

Please sign in to comment.