Port Main Window to React #4853
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (2)
Unchanged files (2)
Total files change -15.21KB -0.12% Final result: ✅ View report in BundleMon website ➡️ |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
blackxored
approved these changes
Apr 23, 2025
| @@ -358,7 +361,7 @@ class GLVolmetersController { | |||
| this.gl.clearColor(bg.r / 255, bg.g / 255, bg.b / 255, 1); | |||
| this.gl.clear(this.gl.COLOR_BUFFER_BIT); | |||
|
|
|||
| if (this.canvasWidth < 0 || this.canvasHeight < 0) return; | |||
| if (this.canvasWidth < 0 || this.canvasHeight < 0 || !this.sourcesOrder) return; | |||
There was a problem hiding this comment.
nit: add braces, control flow can be easy to miss
| @@ -85,14 +89,19 @@ export default function PlatformAppStore(p: { params: { appId?: string; type?: s | |||
| return ( | |||
| <> | |||
| <BrowserView | |||
| className={styles.browserView} | |||
| className={cx(styles.browserView, p.className)} | |||
| style={{ | |||
| height: `calc(100% - ${ | |||
There was a problem hiding this comment.
could we extract this interpolation to a var? seems like we're evaluating a lot
| )} | ||
| </div> | ||
| {(!ctrl.platform || | ||
| (isPlatform(['youtube', 'facebook', 'twitter', 'tiktok', 'kick']) && !isStreaming)) && ( |
There was a problem hiding this comment.
not really a comment, but a note to self, lots of isPlatform evaluations over here, most of the time with the same arguments, that should probably be extracted in the future. It will make it easier to support newer platforms as well instead of having to track all these instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.