Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamlink version check pattern should be case-insensitive #371

Closed
MoshiMoshi0 opened this issue Dec 16, 2016 · 2 comments
Closed

Streamlink version check pattern should be case-insensitive #371

MoshiMoshi0 opened this issue Dec 16, 2016 · 2 comments

Comments

@MoshiMoshi0
Copy link

The version check pattern seen here needs to be case insensitive because the version reported by portable streamlink (on windows) is "Streamlink.exe 0.1.0".

I had to change the source of streamlink to report the version in lowercase to get the gui to work, otherwise I would get "Invalid version check output" error.

@bastimeyer
Copy link
Member

Changing the regexp doesn't solve this issue, the value of the first capture group also needs to be turned into lowercase letters.

The portable version (Streamlink.exe wrapper) is not supported right now. I don't know how I feel about it and if I want to support it, because there are some things that are not that well thought out. When executing Streamlink.exe, there are other unnecessary, meaningless stdout outputs that cause the validation promise to be rejected and I think the strict validation should not be removed. Also the streamlink python script is being modified which causes this issue you're reporting.

What you are doing is selecting the included embedded python executable and the (modified) streamlink python script from the portable-version's directory. You can get all these (unmodified) components from here instead of using the portable version if you don't want or can't use the Streamlink installer:

But let me quickly fix this, so that even your method works...

bastimeyer added a commit that referenced this issue Dec 16, 2016
@bastimeyer
Copy link
Member

Okay, nobody has seen that force push to master 😯 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants