Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for communities #409

Closed
thrstn opened this issue Feb 10, 2017 · 5 comments
Closed

Add support for communities #409

thrstn opened this issue Feb 10, 2017 · 5 comments

Comments

@thrstn
Copy link

thrstn commented Feb 10, 2017

The latest feature on twitch is communities https://www.twitch.tv/directory/communities

The feature is still in beta but the API already supports them https://dev.twitch.tv/docs/v5/reference/communities/

@bastimeyer
Copy link
Member

The v3 API version is still being used here, so communities can't be implemented yet...

Unfortunately, it's not a simple switch, as all channel/stream endpoints are not referenced by names anymore, but by the twitch-users's id, which requires another API request in most cases. I don't know how much work this will be, since I haven't looked into this yet in detail. The deadline for a v5 switch is mid february 2018.

@bastimeyer
Copy link
Member

The Teams API also needs to be checked again (#93). It looks like they have resolved the issues that prevented an implementation.

@bastimeyer
Copy link
Member

The Twitch v5 API upgrade has just been completed: d4e9885

Cummunities and team pages (and also channel news feeds) can now be implemented.

@bastimeyer
Copy link
Member

I'm not yet 100% convinced by the current implementation of the CommunityItemComponent.
It's basically the same as the GameItemComponent, but unlike game images, community avatars are pretty poor sometimes and either don't show the name of the community and what it is about, or are simply missing. So, I think they need to be displayed a bit differently. I'm not sure if always showing the elementes when hovering the component is a good idea (as requested in #315 for the GameItemComponent when game images are missing... missing images can be detected by the API, though, so it could work, but would be ugly for good community images).

@bastimeyer
Copy link
Member

bastimeyer commented Mar 11, 2017

Okay, looks like the LessCSS compiler is breaking the InfiniteScrollMixin when compressing the stylesheets in the production build because of the identical GameItemComponent and CommunityItemComponent stylesheets.

bastimeyer added a commit that referenced this issue Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants