-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation for zh-tw #567
Conversation
Thanks for submitting! |
I've rebase to master, but the ci still failed 😭 |
Yeah, the i18n system is still a bit rough around the edges. One test is failing only on Windows, which is once again a bit surprising. I'll have a look at it... |
Let's ignore the failing test for now. It's unrelated to the pull request or translations in general, anyway. Just a poorly written test that's failing on the slow Appveyor CI container/VM, which is having troubles downloading NW.js all of the time, too. I had added the Appveyor CI after your report #565, when I wasn't aware of the build issues on Windows after the Webpack upgrade recently. Appveyor is the only "sensible" Windows based CI service with Github integration. However, since I knew how bad it actually is, I avoided using it here until then. I'll have to figure out these build fails later today or tomorrow... Regarding your pull request, I'd appreciate if there was someone else who could review this. I can't do this, obviously 😃. |
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
=======================================
Coverage 84.03% 84.03%
=======================================
Files 472 472
Lines 12516 12516
Branches 1218 1218
=======================================
Hits 10518 10518
Misses 1903 1903
Partials 95 95 |
I've fix the 'Twtich' typo |
@dxball There are a couple of missing translations left. Could you please add them, so I can merge this? Thank you! |
@bastimeyer sorry.. I thought there will be someone can help the translation 😮 I've add the missing translations. |
I'm having trouble finding a font that includes all of the used glyphs here. Streamlink Twitch GUI uses Roboto as primary font. Android does the same, but falls back to Noto Sans for CJK fonts. |
I've no idea about the font issue 😅 |
Thanks again for the translations! 👍 I've decided to not include other fonts. The Noto Sans CJK font family is way too large to embed it into the app and it's not worth the effort. However, the app is now properly referring to the Noto Sans system fonts, if installed on the user's system. This should be good enough. |
No description provided.