-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to non-legacy chat url #536
Conversation
Could you please provide a link of the official announcement of this change, please? edit: |
I can't find any announcement about legacy chat, but the chat settings menu gives these options: I noticed that the emote menu feature of BetterTTV was not working with the legacy stylesheet, which is what spurred this. edit: |
That's probably because the chat URLs are not about to be changed. The link you've posted is about restructuring their website (AFAIK, they've switched from EmberJS to React). That doesn't mean that they are changing any critical route names of their website, which would break pretty much everything and would be insanely stupid of them.
We're using the canonical chat URL here for launching the chat in the user's web browser. The popout URL of Twitch is meant for loading different stylesheets/javascript when using the popout feature on their website, which is something different. It's up to BTTV to fix this. I did a bit of research and found a few tweets saying that the restructuring of the Twitch website broke BTTV and similar addons. That's why they included a second popout button, which uses the old (legacy) chat implementation which Twitch hasn't shut down yet. I don't see any reason to switch to the popout chat URL, just because of a bug of a browser addon which hasn't caught up with the recent changes on the Twitch website. I can't blame them though, since the Twitch website has always been terrible and they are breaking stuff all the time, hence this project here. However, sticking with the default chat URL here is a safe choice and bugs related to any browser addon needs to be fixed there, and not here. As a sidenote to this PR, I had a similar one once which wanted to replace the chat URL with the popout URL, although the intention was something different at that time: #117 |
According to the discussion in #551, the currently used chat URL doesn't work when using bits in chat. I've decided to switch to the new popout URL which you've suggested. In #551 there was the suggestion to let the user decide which URL should be opened, but after thinking about it again, just using the popout URL is good enough. |
I don't know what changed in v.1.5 but I can no longer use FrankerFaceZ shortcuts in the new chat browser popout, and the FFZ button isn't showing in the chat input box either. They were working fine in v1.4.1. |
@tmarplatt As an alternative, you can use Chatty, which comes with all of the popular custom emoticon sets, has auto completion and more more features. |
In case this is still relevant: Apparently the whole legacy chat will be removed starting 20th of April (Twitch Announcement) |
Thank you, @skulblakka. When this PR had been opened, the post on the dev forums didn't exist yet and I didn't check the forums again when #536 was opened.
It's a bit odd that the dev post doesn't also mention the popout URL which is being used here now (since it's being used by the website) and is just talking about the embed URL. There are a few minor differences between the popout chat and embedded chat, but I guess it's essentially the same and there won't be any risks in using the popout chat (as default) at least for now. Regarding BTTV, FFZ and all the related browser extensions, these have to be fixed by their devs, as I've said. All that can be done here is choosing one of the supported chat URLs for browser based chat providers. And regarding missing moderation features in the new chat, there's nothing that can be done here either, as it's Twitch's decision to remove them from their new popout/embed chat.
I guess the legacy URL can be removed from the chat selection which I have implemented in #554 (not included in 1.5.0). An originally set deprecation time of 21 days, now extended to a bit more than a month. How generous of them. /s
I agree 100% with this user comment... |
Twitch recently moved the current chat URL to legacy. Updated the chat URL.