i18n/de: Add German translations #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 84.13% 84.15% +0.02%
==========================================
Files 474 474
Lines 12518 12518
Branches 1221 1221
==========================================
+ Hits 10532 10535 +3
+ Misses 1893 1890 -3
Partials 93 93 |
skulblakka
reviewed
Jul 27, 2018
src/app/locales/de/settings.yml
Outdated
| channels: | ||
| find: Kanal finden | ||
| none: Keine Kanäle gefunden. | ||
| empty: Keine benutzerdefinierten Kanäleinstellungen gesetzt. |
There was a problem hiding this comment.
Should probably say "Keine benutzerdefinierten Kanaleinstellungen gesetzt."
src/app/locales/de/settings.yml
Outdated
| grouping: | ||
| title: Gruppieren | ||
| description: Mehrere Benachrichtigungen zusammenfassen. | ||
| checkbox: Nur eine Benachrichtigungen auf einmal anzeigen |
There was a problem hiding this comment.
Should say "Nur eine Benachrichtigung auf einmal anzeigen"
|
thanks @skulblakka for taking the time and finding these stupid mistakes 👍 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a PR instead of just pushing the changes to the master branch, so that it can be reviewed...
If nobody will review or even see this within the next days, I will just merge it (probably after this weekend), because I want to finally publish a new release. I want to have this included, even if the translations are not good enough, I don't really care.
Had a bit of trouble finding good translations here and there while not trying to make it sound weird or trying to use more anglicisms than needed. Some texts are also no direct translations, because translating didn't make sense or because I changed it after already translating it.
This also made me realize how inconsistent all of the English texts are and that they need to be improved. Will do this after switching to the new Twitch API, which will require lots of changes anyway.