Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isWin test in LivestreamerController.js #6

Merged
merged 2 commits into from
May 6, 2014

Conversation

bsdf
Copy link
Contributor

@bsdf bsdf commented May 5, 2014

process.platform on os x is "darwin" which matches the /win/ regex

@bastimeyer
Copy link
Member

Can you please update this PR and remove the dollar-anchor in the regexp so I can merge this? process.platform on windows is win32...
Thanks!

bastimeyer added a commit that referenced this pull request May 6, 2014
Fix isWin test in LivestreamerController.js
@bastimeyer bastimeyer merged commit 50c3c78 into streamlink:master May 6, 2014
@DrPugsley DrPugsley mentioned this pull request Apr 24, 2017
4 tasks
@undeference undeference mentioned this pull request May 7, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants