Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n/fr: Fix some of the french translation #826

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

someone1239
Copy link
Contributor

Hello,

This is an update for the current french translation. Most of it is minor changes (punctuation, 's' added when plural) but I also corrected a few wrong translations (fade out streams for example) and added a few missing strings (--no-keepaspect-window setting, fade and filter in language settings).

Let me know if I need to change some things. The tests run fine, but I had to rebase my commits because I forgot the "i18n/fr" in the commit messages, so hopefully I didn't break stuff :/

Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fixes and also for adding the missing settings.player.players.mpv.attributes.no-keepaspect-window translations.

Just one or two minor concerns regarding the spacing around colons in certain headlines.

src/app/locales/fr/modal.yml Outdated Show resolved Hide resolved
src/app/locales/fr/routes.yml Outdated Show resolved Hide resolved
@bastimeyer bastimeyer added the i18n label Sep 6, 2021
modal.yml -> removed spaces before colons
routes.yml -> added spaces before colons
@bastimeyer bastimeyer merged commit 5f9b18c into streamlink:master Sep 6, 2021
@bastimeyer
Copy link
Member

Thanks, appreciated!

@someone1239 someone1239 deleted the fr-translation branch September 6, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants