plugins.filmon: rewrite plugin #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite FilmOnHLS{,Worker}
- Override fetching logic of HLSStreamWorker._fetch_playlist
- Rewrite playlist URL refresh logic and move everything to the
FilmOnHLSStream.url property
- Clean up FilmOnAPI and schemas
- Clean up FilmOn plugin class
- Move http adapter definitions to constructor
- Set hls-playlist-reload-time to "segment"
- Clean up _get_streams
- Fix tests
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Jun 7, 2022
- Rewrite FilmOnHLS{,Worker}
- Override fetching logic of HLSStreamWorker._fetch_playlist
- Rewrite playlist URL refresh logic and move everything to the
FilmOnHLSStream.url property
- Clean up FilmOnAPI and schemas
- Clean up FilmOn plugin class
- Move http adapter definitions to constructor
- Set hls-playlist-reload-time to "segment"
- Clean up _get_streams
- Fix tests
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Jun 7, 2022
- Rewrite FilmOnHLS{,Worker}
- Override fetching logic of HLSStreamWorker._fetch_playlist
- Rewrite playlist URL refresh logic and move everything to the
FilmOnHLSStream.url property
- Clean up FilmOnAPI and schemas
- Clean up FilmOn plugin class
- Move http adapter definitions to constructor
- Set hls-playlist-reload-time to "segment"
- Clean up _get_streams
- Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilmOnHLSStream.url property
No idea why the channel ID caching was implemented, but I kept it.
Reducing the HLS playlist reload time seemed to be necessary to not cause any issues when updating the playlist URL. Otherwise, segments were missing sometimes, leading to discontinuities in the stream. This could still be the case though, not sure, but it's an improvement compared to the old implementation.
Also not sure how relevant the 403 and 502 status code exception handling still is. At least it doesn't check the exception message anymore.