stream.hls: stop stream early on missing segments #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename attibute for consistency reasons and change its type to float, despite RFC 8216 describing it as an integer (permissive parsing).
Stop the stream early if no new segments were queued by the worker after the playlist's `targetduration * 2` has passed. Use the timing factor of `2` to prevent potential issues with the reload timing of the playlist or when a stream discontinuity occurs.
bastimeyer
changed the title
3 tasks
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop the stream early if no new segments were queued by the worker after the playlist's
targetduration * 2has passed.Use the timing factor of
2to prevent potential issues with the reload timing of the playlist or when a stream discontinuity occurs.https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.3.1
Resolves #2198
See #2198 (comment)
Before this can get merged, lots of testing with real-world data needs to be done. Stopping the stream early when there's no reason for it would be pretty bad.
These changes don't affect ad filtering, because this is done in the worker thread where it doesn't write the data to the output buffer. Ad segments still get queued by the worker, so the queue timing threshold won't be reached by filtering out ads.
Please help me test this.