Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.nicolive: add metadata #5529

Merged

Conversation

bastimeyer
Copy link
Member

Resolves #5515

I am not sure though if this could break some streams, because metadata is not treated optionally, so if it's missing, then the validation schema could fail.

@SecondaryH could you please check some more streams (preferrably with a login - which I don't have) and verify these changes? Thanks!
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback


Some streams I've checked:

1. From the tests file:

streamlink --json https://live.nicovideo.jp/watch/co2619719 best | jq .metadata
{
  "id": "lv342666086",
  "author": "novoll(千葉県民)",
  "category": null,
  "title": "【SFC】魔法騎士レイアース 初見プレイ【13枠目】"
}

2. Picked randomly from their site

streamlink --json https://live.nicovideo.jp/watch/lv342666014 best | jq .metadata
{
  "id": "lv342666014",
  "author": "ノンケのねねし",
  "category": null,
  "title": "【スト6】9月16日、17日に仙台で大規模大会があります(ラウンジ)【ノンケ配信記】"
}

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Sep 3, 2023
@SecondaryH
Copy link

Thanks for picking this up! Appreciate it!

I spent about an hour testing this with various livestreamers,vods,logged in,logged out,premium user etc and from what I can see it works perfectly!

I tried grabbing a full log but unfortunately encountered some errors. See #5531

incomplete logfile

I've omitted some id's/tokens because they might be sensitive.

@bastimeyer bastimeyer force-pushed the plugins/nicolive/add-metadata branch from 57c5e44 to 616096e Compare September 3, 2023 18:59
@bastimeyer
Copy link
Member Author

Thanks for testing. The encoding bug with the log file on Windows should be fixed on master now.

I force-pushed another change an hour ago here which fixes the detection of offline streams which I broke when I removed the unnecessary suppression of schema validation errors.

Going to merge now.

@bastimeyer bastimeyer merged commit ad6952c into streamlink:master Sep 3, 2023
@bastimeyer bastimeyer deleted the plugins/nicolive/add-metadata branch September 3, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins.nicolive: plugin does not support stream metadata
2 participants