Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5515
I am not sure though if this could break some streams, because metadata is not treated optionally, so if it's missing, then the validation schema could fail.
@SecondaryH could you please check some more streams (preferrably with a login - which I don't have) and verify these changes? Thanks!
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
Some streams I've checked:
1. From the tests file:
streamlink --json https://live.nicovideo.jp/watch/co2619719 best | jq .metadata
2. Picked randomly from their site
streamlink --json https://live.nicovideo.jp/watch/lv342666014 best | jq .metadata