Fix TOC hierarchy on floating nav #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snehankekre
approved these changes
Dec 21, 2022
Contributor
snehankekre
left a comment
snehankekre
left a comment
There was a problem hiding this comment.
Thanks for the fix, Juan! Looks great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This PR fixes an issue reported by @arnaudmiribel a while back here where the table of contents on the documentation site was behaving in a strange way, hiding some titles and showing the wrong hierarchy.
This was caused by how we used to hide the first
h1, which we don't want to show on the TOC, and this PR aims to fix that.🧠 Description of Changes
Revised:
Current:
💥 Impact
Size:
🌐 References
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.