Set Python 3.13 as max version for Streamlit #9635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
lukasmasuch
changed the title
raethlein
force-pushed
the
upgrade-python313
branch
2 times, most recently
from
1e4ff5b to
fb50751
Compare
raethlein
force-pushed
the
upgrade-python313
branch
2 times, most recently
from
9472c25 to
c9c3edc
Compare
4 tasks
raethlein
force-pushed
the
upgrade-python313
branch
from
c9c3edc to
d771b00
Compare
raethlein
commented
Nov 25, 2024
There was a problem hiding this comment.
It looks like the warning icon on Chromium is now the same as on Webkit and Firefox in the updated playwright version
raethlein
commented
Nov 25, 2024
There was a problem hiding this comment.
Apparently, the indicator of which function raised the error changed in Python 3.13. However, it looks like we want to simplify the traces anyways as demonstrated in this PR: #9913
raethlein
changed the title
raethlein
added a commit
that referenced
this pull request
Nov 25, 2024
…nt (#9919) ## Describe your changes Fixes an issue in our build pipeline when mypy is run (see [here](https://github.com/streamlit/streamlit/actions/runs/12004642925)) by removing the comment. We set Python 3.9 as the new min as 3.8 would still require the comment. We are about to bump the max version to 3.13 and want to retire 3.8: #9635 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
raethlein
force-pushed
the
upgrade-python313
branch
from
385fcbf to
edc20e7
Compare
raethlein
changed the title
kmcgrady
pushed a commit
that referenced
this pull request
Nov 25, 2024
…nt (#9919) ## Describe your changes Fixes an issue in our build pipeline when mypy is run (see [here](https://github.com/streamlit/streamlit/actions/runs/12004642925)) by removing the comment. We set Python 3.9 as the new min as 3.8 would still require the comment. We are about to bump the max version to 3.13 and want to retire 3.8: #9635 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
kmcgrady
pushed a commit
that referenced
this pull request
Nov 25, 2024
…nt (#9919) ## Describe your changes Fixes an issue in our build pipeline when mypy is run (see [here](https://github.com/streamlit/streamlit/actions/runs/12004642925)) by removing the comment. We set Python 3.9 as the new min as 3.8 would still require the comment. We are about to bump the max version to 3.13 and want to retire 3.8: #9635 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
raethlein
force-pushed
the
upgrade-python313
branch
from
334f8e8 to
1d14404
Compare
sfc-gh-bnisco
approved these changes
Nov 26, 2024
raethlein
force-pushed
the
upgrade-python313
branch
from
576f9c9 to
736e0cc
Compare
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…nt (streamlit#9919) ## Describe your changes Fixes an issue in our build pipeline when mypy is run (see [here](https://github.com/streamlit/streamlit/actions/runs/12004642925)) by removing the comment. We set Python 3.9 as the new min as 3.8 would still require the comment. We are about to bump the max version to 3.13 and want to retire 3.8: streamlit#9635 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
**Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
See previous upgrade to 3.12 for reference: #7663
Some screenshots are updated because we had to update the playwright dependency to
>= 1.48. I have moved those changes to its own PR for easier review: #9918 Since playwright >= 1.48 requires Python 3.9 as a minimum, we remove support for Python 3.8 here: #9919Action Items:
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.