Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sn-platform][sn-platform-slim]: move kop ports and auth configurations to broker.kop #1081

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Aug 2, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

To make the kop configuration under the same location.

Modifications

move kop ports and auth configurations to broker.kop

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

ericsyh added 2 commits August 2, 2023 10:57
Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
@ericsyh ericsyh added this to the sn-platform-1.11 milestone Aug 2, 2023
@ericsyh ericsyh requested a review from a team August 2, 2023 03:06
@ericsyh ericsyh requested review from sijie, addisonj and a team as code owners August 2, 2023 03:06
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Aug 2, 2023
ericsyh added 2 commits August 2, 2023 15:44
Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
@ericsyh ericsyh merged commit 2efc1d6 into master Sep 15, 2023
@ericsyh ericsyh deleted the kop-update branch September 15, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-change no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants