Make build-in prom compatible with mergeMetrics feature #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsyh
approved these changes
Nov 21, 2024
ericsyh
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Make buildin prom compatible with mergeMetrics feature * Disable prom Istio when mergeMetrics * Disable prom Istio when mergeMetrics (cherry picked from commit d0965ba)
ericsyh
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Make buildin prom compatible with mergeMetrics feature * Disable prom Istio when mergeMetrics * Disable prom Istio when mergeMetrics (cherry picked from commit d0965ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow external non-Istio prometheus and build-in prometheus to scrape Pulsar metrics simultaneously
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)