Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new GitHub action to cover cases when JarLocation/PyLocation/GoLocation is specified #401

Closed
jiangpengcheng opened this issue Jun 20, 2022 · 7 comments · Fixed by #429

Comments

@jiangpengcheng
Copy link
Member

No description provided.

@jiangpengcheng jiangpengcheng changed the title CI task add new GitHub action to cover cases when JarLocation/PyLocation/GoLocation is specified add new GitHub action to cover cases when JarLocation/PyLocation/GoLocation is specified Jun 20, 2022
@freeznet freeznet added this to the 2022-07 v0.4.0 milestone Jun 28, 2022
@jiangpengcheng jiangpengcheng self-assigned this Jun 28, 2022
@tpiperatgod
Copy link
Contributor

as mentioned in #314, we can use skywalking-e2e-infra to support this action. I will first setup the basic framework for this.

@tpiperatgod tpiperatgod self-assigned this Jun 29, 2022
@tpiperatgod
Copy link
Contributor

tpiperatgod commented Jul 2, 2022

I have done the main work, but I found that the action does not work properly in the environment provided by GitHub, but it works in the local and in the self-hosted runner...it's weird.

run on GitHub: https://github.com/tpiperatgod/function-mesh/actions/runs/2599914361
run on self-hosted runner: https://github.com/tpiperatgod/function-mesh/actions/runs/2599816397

If this issue is still unresolved in the next few days, I would prefer to use the kubectl wait command instead of skywalking-e2e-infra to optimize the ci workflows...

And if it is unable to introduce skywalking-e2e-infra into ci workflows, we can still use it for local e2e testing, e.g. with make e2e

@jiangpengcheng
Copy link
Member Author

seems like it timed out, maybe can retry for several times

@tpiperatgod
Copy link
Contributor

seems like it timed out, maybe can retry for several times

I've tried but failed...

I plan to keep skywalking-e2e-infra as a local e2e tests framework, what do you think? 🫠

@jiangpengcheng
Copy link
Member Author

seems like it timed out, maybe can retry for several times

I've tried but failed...

I plan to keep skywalking-e2e-infra as a local e2e tests framework, what do you think? 🫠

what does the local mean? it won't be triggered by GitHub actions but can be run manually in our local environment?

@tpiperatgod
Copy link
Contributor

what does the local mean? it won't be triggered by GitHub actions but can be run manually in our local environment?

yes, just type a command like make e2e

@jiangpengcheng
Copy link
Member Author

I'm ok with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants