-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make e2e
command for e2e tests based on skywalking-e2e-infra
#422
Conversation
Currently we can't use skywalking-e2e-infra for github action directly, mainly because of the resource limitation of github action itself. So I have temporarily integrated this e2e testing framework into the There are test cases in the I think we can wait for #420 to be reviewed and merged before reviewing the PR, because some of the improvements in #420 also help the PR |
I think this PR is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, PTAL, thanks.
@jiangpengcheng @danpi @nlu90 need an eye on this one, thanks. |
is this still not working in Github Action? |
Yes, because of resource limitations (CPU, memory, disk etc.). |
There is a way to bypass the resource limitations by removing the |
Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
It works 🙃 |
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #401 #314
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
make e2e
command for e2e tests based on skywalking-e2e-infraVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)