Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make e2e command for e2e tests based on skywalking-e2e-infra #422

Merged
merged 4 commits into from
Jul 15, 2022
Merged

Add make e2e command for e2e tests based on skywalking-e2e-infra #422

merged 4 commits into from
Jul 15, 2022

Conversation

tpiperatgod
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #401 #314

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  • add make e2e command for e2e tests based on skywalking-e2e-infra

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tpiperatgod tpiperatgod requested review from nlu90, freeznet and a team as code owners July 9, 2022 07:11
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 9, 2022
@tpiperatgod
Copy link
Contributor Author

Currently we can't use skywalking-e2e-infra for github action directly, mainly because of the resource limitation of github action itself.

So I have temporarily integrated this e2e testing framework into the make e2e command, which has the advantage that we can reduce the usage of github action and make it easier for us to verify the functionality locally.

There are test cases in the .ci/tests/integration/cases directory, currently there is only one java-function test case, you can refer to it to add new test cases.

I think we can wait for #420 to be reviewed and merged before reviewing the PR, because some of the improvements in #420 also help the PR

@freeznet freeznet added area/ci type/feature Indicates new functionality m/2022-07 labels Jul 11, 2022
@tpiperatgod
Copy link
Contributor Author

I think this PR is ready.

Copy link
Member

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, PTAL, thanks.

.ci/tests/kind.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@freeznet freeznet requested review from danpi and jiangpengcheng July 13, 2022 00:56
@freeznet
Copy link
Member

@jiangpengcheng @danpi @nlu90 need an eye on this one, thanks.

@jiangpengcheng
Copy link
Member

jiangpengcheng commented Jul 13, 2022

is this still not working in Github Action?

@tpiperatgod
Copy link
Contributor Author

is this still not working in Github Action?

Yes, because of resource limitations (CPU, memory, disk etc.).

@tpiperatgod
Copy link
Contributor Author

There is a way to bypass the resource limitations by removing the .resources, and I thought we could try this.

Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
Signed-off-by: laminar <tpiperatgod@gmail.com>
@tpiperatgod
Copy link
Contributor Author

There is a way to bypass the resource limitations by removing the .resources, and I thought we could try this.

It works 🙃

@freeznet freeznet merged commit 9699e70 into streamnative:master Jul 15, 2022
@tpiperatgod tpiperatgod deleted the issue-401 branch July 15, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci m/2022-07 no-need-doc This pr does not need any document type/feature Indicates new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants