Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Function Mesh Labels #449

Closed
nlu90 opened this issue Aug 16, 2022 · 0 comments · Fixed by #451
Closed

Improve Function Mesh Labels #449

nlu90 opened this issue Aug 16, 2022 · 0 comments · Fixed by #451
Assignees
Labels
component/controller m/2022-09 type/enhancement Indicates an improvement to an existing feature

Comments

@nlu90
Copy link
Contributor

nlu90 commented Aug 16, 2022

Ref https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
And follow Pulsar-Operator label convention.
Notive line 23 and line 28

 16   labels:
 17     cloud.streamnative.io/location: us-east4
 18     cloud.streamnative.io/poolmember-name: us-east4
 19     cloud.streamnative.io/poolmember-namespace: streamnative
 20     cloud.streamnative.io/pulsar-cluster: logging
 21     cloud.streamnative.io/pulsar-instance: unifiedob
 22     cloud.streamnative.io/role: pulsar-function
 23     component: sink // <- add ?.functionmesh.io prefix
 24     controller-revision-hash: es-logs-with-ts-3e5094bd-sink-79b5875974
 25     name: es-logs-with-ts-3e5094bd
 26     namespace: sncloud
 27     pulsar-cluster: logging
 28     pulsar-component: es-logs-with-ts // <--- meaning not clear
 29     pulsar-namespace: sncloud-prod
 30     pulsar-tenant: uo
 31     statefulset.kubernetes.io/pod-name: es-logs-with-ts-3e5094bd-sink-7
@freeznet freeznet added type/enhancement Indicates an improvement to an existing feature component/controller m/2022-09 labels Aug 17, 2022
@freeznet freeznet added this to the 2022-09 v0.6.0 milestone Aug 17, 2022
@tpiperatgod tpiperatgod self-assigned this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/controller m/2022-09 type/enhancement Indicates an improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants